Add type as required property in source object of webhook#484
Closed
github-actions[bot] wants to merge 1 commit intomasterfrom
Closed
Add type as required property in source object of webhook#484github-actions[bot] wants to merge 1 commit intomasterfrom
github-actions[bot] wants to merge 1 commit intomasterfrom
Conversation
Contributor
sig/** is missing
|
Contributor
|
let me fix this in another PR |
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 9, 2025
it's missing (found in #484)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
line/line-openapi#103
In the Messaging API webhook, we use
discriminatorto differentiate classes based on the value oftype. During the development of bot SDK for Ruby v2, it seems that onlySourcedoes not havetypemarked as required. This is simply a mistake. The type should always be included to distinguish the kind of JSON, and there should not be any instances where it is absent.