refactor: freeze dependencies for plugins and move it to build time#515
refactor: freeze dependencies for plugins and move it to build time#515
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| OSS Licenses | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
There was a problem hiding this comment.
✨ PR Review
Agentic review
Freezing plugin deps to build time raises a concern: the vendor script pins non-existent package versions that break the build, so this needs work.
1 issues detected:
🐞 Bug - Non-existent package versions break build-time vendor step
Details: The
vendor-pluginsscript inpackage.json:33pins non-existent package versions:lodash@4.18.1(max published is4.17.21) and@octokit/rest@20.1.1(lock file shows20.1.2). Sincenpm run packagenow chains this script, a failingnpm installwill hard-abort the entire build pipeline, unlike the previouscontinue-on-error: truestep. Update the pins tolodash@4.17.21and@octokit/rest@20.1.2to match published versions and the lock file.
File:package.json (33-33)
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how
false positive |
|
/dev env=yeela rune2e=true |
✨ PR Description
Purpose: Move plugin dependency installation from runtime workflow to build time to improve action execution performance and eliminate npm cache operations.
Main changes:
Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how