Skip to content

refactor: freeze dependencies for plugins and move it to build time#515

Open
yeelali14 wants to merge 1 commit intodevelopfrom
LINBEE-24063
Open

refactor: freeze dependencies for plugins and move it to build time#515
yeelali14 wants to merge 1 commit intodevelopfrom
LINBEE-24063

Conversation

@yeelali14
Copy link
Copy Markdown
Contributor

@yeelali14 yeelali14 commented Apr 9, 2026

✨ PR Description

Purpose: Move plugin dependency installation from runtime workflow to build time to improve action execution performance and eliminate npm cache operations.

Main changes:

  • Removed runtime npm installation steps (cache clean and dependency install) from GitHub Action workflow
  • Added vendor-plugins script to package.json that installs frozen plugin dependencies during build process
  • Configured NODE_PATH environment variable to reference bundled node_modules for plugin resolution at runtime

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Description using Guidelines Learn how

Copy link
Copy Markdown

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed OSS Licenses high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@linearb linearb bot added the 1 min review label Apr 9, 2026
Copy link
Copy Markdown

@linearb linearb bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ PR Review

Agentic review
Freezing plugin deps to build time raises a concern: the vendor script pins non-existent package versions that break the build, so this needs work.

1 issues detected:

🐞 Bug - Non-existent package versions break build-time vendor step

Details: The vendor-plugins script in package.json:33 pins non-existent package versions: lodash@4.18.1 (max published is 4.17.21) and @octokit/rest@20.1.1 (lock file shows 20.1.2). Since npm run package now chains this script, a failing npm install will hard-abort the entire build pipeline, unlike the previous continue-on-error: true step. Update the pins to lodash@4.17.21 and @octokit/rest@20.1.2 to match published versions and the lock file.
File: package.json (33-33)

Generated by LinearB AI and added by gitStream.
AI-generated content may contain inaccuracies. Please verify before using.
💡 Tip: You can customize your AI Review using Guidelines Learn how

@yeelali14
Copy link
Copy Markdown
Contributor Author

✨ PR Review

Agentic review Freezing plugin deps to build time raises a concern: the vendor script pins non-existent package versions that break the build, so this needs work.

1 issues detected:

🐞 Bug - Non-existent package versions break build-time vendor step
Details: The vendor-plugins script in package.json:33 pins non-existent package versions: lodash@4.18.1 (max published is 4.17.21) and @octokit/rest@20.1.1 (lock file shows 20.1.2). Since npm run package now chains this script, a failing npm install will hard-abort the entire build pipeline, unlike the previous continue-on-error: true step. Update the pins to lodash@4.17.21 and @octokit/rest@20.1.2 to match published versions and the lock file.
File: package.json (33-33)

Generated by LinearB AI and added by gitStream. AI-generated content may contain inaccuracies. Please verify before using. 💡 Tip: You can customize your AI Review using Guidelines Learn how

false positive

@yeelali14
Copy link
Copy Markdown
Contributor Author

/dev env=yeela rune2e=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant