Skip to content

Commit 72feb00

Browse files
committed
Update x86 comments
1 parent 5dbb370 commit 72feb00

1 file changed

Lines changed: 3 additions & 5 deletions

File tree

fearless_simd_gen/src/mk_x86.rs

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -230,7 +230,7 @@ impl X86 {
230230
let gt = simple_sign_unaware_intrinsic("cmpgt", vec_ty);
231231

232232
if vec_ty.scalar == ScalarType::Unsigned {
233-
// SSE4.2 only has signed GT/LT, but not unsigned.
233+
// Below AVX-512, we only have signed GT/LT, not unsigned.
234234
let set = set1_intrinsic(vec_ty);
235235
let sign = match vec_ty.scalar_bits {
236236
8 => quote! { 0x80u8 },
@@ -451,8 +451,7 @@ impl X86 {
451451
quote! {
452452
let (a, b) = self.#split(a);
453453
unsafe {
454-
// Note that SSE4.2 only has an intrinsic for saturating cast,
455-
// but not wrapping.
454+
// Below AVX-512. we only have an intrinsic for saturating cast, but not wrapping.
456455
let mask = #mask(0xFF);
457456
let lo_masked = _mm_and_si128(a.into(), mask);
458457
let hi_masked = _mm_and_si128(b.into(), mask);
@@ -547,8 +546,7 @@ impl X86 {
547546
let shift_intrinsic = intrinsic_ident(op, suffix, ty_bits);
548547

549548
if vec_ty.scalar_bits == 8 {
550-
// SSE doesn't have shifting for 8-bit, so we first convert into
551-
// 16 bit, shift, and then back to 8-bit
549+
// x86 doesn't have shifting for 8-bit, so we first convert into 16-bit, shift, and then back to 8-bit.
552550

553551
let unpack_hi = unpack_intrinsic(ScalarType::Int, 8, false, ty_bits);
554552
let unpack_lo = unpack_intrinsic(ScalarType::Int, 8, true, ty_bits);

0 commit comments

Comments
 (0)