Add instructions and a script for hosting Office Hours.#116
Add instructions and a script for hosting Office Hours.#116PoignardAzur wants to merge 3 commits into
Conversation
DJMcNab
left a comment
DJMcNab
left a comment
There was a problem hiding this comment.
I think having some docs here is helpful; I don't think they need to be as prominent as you've made them.
There was a problem hiding this comment.
If it's possible under Zola, I'd probably put this page as a sub-page of Office Hours; it doesn't really make sense as a top-level thing
There was a problem hiding this comment.
I don't think it matters. The wiki folder is already very chaotic anyway. It's not valuable real estate.
| } | ||
| } | ||
|
|
||
| return `[#${issue.number}](${issue.html_url}) (${label}) - ${issue.title}`; |
There was a problem hiding this comment.
For e.g. kurbo/peniko or android-view/accesskit or resvg/usvg/tiny-skia etc, we normally include which specific repository from that group the issue corresponds to. I see you've chosen not to do so this week - is there a reason? Maybe there's some indicator that I'm not spotting.
There was a problem hiding this comment.
I've added the repo name to all issues for simplicity.
| "linebender/linebender.github.io", | ||
| ]; | ||
|
|
||
| const since = new Date(Date.now() - 7 * 24 * 60 * 60 * 1000).toISOString(); |
There was a problem hiding this comment.
It could be nice to use 8am PDT/PST on office hours day (maybe just on the given day?), so that stuff doesn't accidentally get included twice (especially when you're not manually looking at the times). Maybe 6:30am, which gives a 90 minute window to make this?
There was a problem hiding this comment.
I'd rather avoid getting too clever here. This is supposed to be a simple-ish script. The user can just filter out older issues manually.
| if (!isPR && createdRecently) { | ||
| label = "open issue"; | ||
| } else if (isPR) { | ||
| // Fetch PR details to determine draft/merged status |
There was a problem hiding this comment.
It's very strange that GitHub's API doesn't include this info (it even includes the PR body!), but I agree that it seems like you have to do this.
|
Something I'd like to note is, I think it's fine if the script doesn't perfectly sort issues or gives some redundant info, as long as it doesn't give outright false info. The user should still be expected to do the work of sorting items and curating them for Office Hours. |
|
Do we still think this is valuable? Otherwise I'd rather close the PR. |
|
I'm unlikely to make use of this resource, and I'm generally the only person who makes the document and fills out the agenda. |
2 participants
No description provided.