Separate owners from super-owners in their access.#5652
Open
MathieuDutSik wants to merge 8 commits into
Open
Conversation
MathieuDutSik
force-pushed
the
issue_5269_chain_super_owners
branch
3 times, most recently
from
be61910 to
fc34eea
Compare
MathieuDutSik
force-pushed
the
issue_5269_chain_super_owners
branch
from
2f80947 to
87f14be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We have owners and super-owners. However, there is a privilege escalation mechanism that allows an owner to change the super-owners, and so do something the chain was not designed for.
Fixes #5269
Proposal
The owners can change the owners, but not the super-owners. They also cannot change the fast part of the creation of a block, only super owners can do that.
The changes then follow from that.
Of course, if a chain has no super-owners, it can never have any.
Test Plan
CI and add some tests to check that
Release Plan
It is interesting to see whether we can backport it to
testnet_conway.Links
None