fix(ci): skip Bridge E2E on fork PRs due to missing OIDC tokens#5753
Closed
eldios wants to merge 1 commit into
Closed
fix(ci): skip Bridge E2E on fork PRs due to missing OIDC tokens#5753eldios wants to merge 1 commit into
eldios wants to merge 1 commit into
Conversation
GitHub Actions does not inject OIDC tokens ($ACTIONS_ID_TOKEN_REQUEST_TOKEN) for pull_request events from forks. This causes google-github-actions/auth@v2 to fail since GCP Workload Identity Federation requires id-token: write permission. Add a condition to skip the bridge-e2e job on fork PRs while keeping it running for same-repo PRs, push events, merge_group, and workflow_dispatch. Closes #5751
deuszx
reviewed
Mar 19, 2026
Comment on lines
+30
to
+34
| # Skip on fork PRs: GCP Workload Identity Federation requires OIDC tokens | ||
| # that GitHub does not inject for pull_request events from forks. | ||
| if: >- | ||
| github.event_name != 'pull_request' | ||
| || github.event.pull_request.head.repo.full_name == github.repository |
Contributor
There was a problem hiding this comment.
We should just remove it from running on pull_request.
Contributor
There was a problem hiding this comment.
This is removed already on testnet_conway
Contributor
|
This PR can be closed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bridge-e2ejob on fork PRs since GitHub Actions does not inject OIDC tokens ($ACTIONS_ID_TOKEN_REQUEST_TOKEN) forpull_requestevents from forks, causinggoogle-github-actions/auth@v2to failContext
The
bridge-e2e.ymlworkflow uses GCP Workload Identity Federation which requiresid-token: writepermission. GitHub restricts this for fork PRs as a security measure to prevent secrets exfiltration.Investigation confirmed the pattern: all
fork=Trueruns failed, allfork=Falseruns succeeded.Test Plan
ifconditiongithub.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repositorycorrectly evaluates to:truefor push, merge_group, workflow_dispatch (non-PR events)truefor same-repo PRsfalsefor fork PRs onlyCloses #5751