Remove notifiers from the list when closed.#5796
Closed
MathieuDutSik wants to merge 2 commits into
Closed
Conversation
Contributor
|
Maybe I'm confused about the notifiers, but: Is that really doing anything? Entries should get removed automatically anyway as soon as the cross-chain messages from the corresponding height have been delivered, shouldn't they? If delivery takes so long that while it's pending we'd run multiple sweeps that seems like a problem in itself. Or are they accumulating due to some interaction with the set of tracked chains? Then we should probably fix that underlying issue and make sure notifiers are removed as soon as no tracked chains are left that are waiting for message delivery? |
Contributor
Author
|
That PR does not seem to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We are exposed to OOM problems.
A small place where we can improve the situation is with respect to dead notifiers: We need to remove them.
Proposal
We do the following:
Test Plan
CI.
Release Plan
Can be backported to
testnet_conway.Links
None