Skip to content

Remove notifiers from the list when closed.#5796

Closed
MathieuDutSik wants to merge 2 commits into
linera-io:mainfrom
MathieuDutSik:validator_oom
Closed

Remove notifiers from the list when closed.#5796
MathieuDutSik wants to merge 2 commits into
linera-io:mainfrom
MathieuDutSik:validator_oom

Conversation

@MathieuDutSik
Copy link
Copy Markdown
Contributor

Motivation

We are exposed to OOM problems.
A small place where we can improve the situation is with respect to dead notifiers: We need to remove them.

Proposal

We do the following:

  • When registering a sender, drop the closed ones.
  • The background sweep is now done even when no TTL is set.
  • The sweep process stops when there is no notifiers to take care of.

Test Plan

CI.

Release Plan

Can be backported to testnet_conway.

Links

None

@MathieuDutSik MathieuDutSik marked this pull request as ready for review March 25, 2026 08:49
@afck
Copy link
Copy Markdown
Contributor

afck commented Mar 26, 2026

Maybe I'm confused about the notifiers, but: Is that really doing anything? Entries should get removed automatically anyway as soon as the cross-chain messages from the corresponding height have been delivered, shouldn't they? If delivery takes so long that while it's pending we'd run multiple sweeps that seems like a problem in itself.

Or are they accumulating due to some interaction with the set of tracked chains? Then we should probably fix that underlying issue and make sure notifiers are removed as soon as no tracked chains are left that are waiting for message delivery?

@MathieuDutSik
Copy link
Copy Markdown
Contributor Author

That PR does not seem to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants