Skip to content

Add version to tikv-jemallocator git dependency to fix docs CI#5860

Merged
ndr-ds merged 1 commit into
testnet_conwayfrom
ndr-ds/fix-docs-test-tikv-version
Mar 28, 2026
Merged

Add version to tikv-jemallocator git dependency to fix docs CI#5860
ndr-ds merged 1 commit into
testnet_conwayfrom
ndr-ds/fix-docs-test-tikv-version

Conversation

@ndr-ds
Copy link
Copy Markdown
Contributor

@ndr-ds ndr-ds commented Mar 27, 2026

Motivation

The test-crates-and-docrs CI job has been failing on testnet_conway since the
backport of #5602 (#5792). cargo package requires all dependencies to have a version
field — the backport included the git spec but dropped version = "0.6".

Proposal

Add version = "0.6" to the tikv-jemallocator workspace dependency, matching what
#5602 has on main. The [patch.crates-io] section still ensures the git fork is used
at build time; the version is only needed so cargo package knows what to reference
when
stripping git specs for packaging.

Also temporarily adds a pull_request trigger to the Documentation workflow so the fix
can be verified on this PR before merging. This trigger should be removed before or
after merge.

Test Plan

  • CI — the test-crates-and-docrs job will run on this PR via the temporary trigger

@ndr-ds ndr-ds force-pushed the ndr-ds/fix-docs-test-tikv-version branch 3 times, most recently from 3fb3913 to 0bbab2f Compare March 28, 2026 03:22
@ndr-ds
Copy link
Copy Markdown
Contributor Author

ndr-ds commented Mar 28, 2026

Merging since this partially breaks the docs tests

@ndr-ds ndr-ds merged commit 4227e55 into testnet_conway Mar 28, 2026
10 checks passed
@ndr-ds ndr-ds deleted the ndr-ds/fix-docs-test-tikv-version branch March 28, 2026 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant