Add version to tikv-jemallocator git dependency to fix docs CI#5860
Merged
Conversation
3fb3913 to
0bbab2f
Compare
Contributor
Author
|
Merging since this partially breaks the docs tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
test-crates-and-docrsCI job has been failing ontestnet_conwaysince thebackport of #5602 (#5792).
cargo packagerequires all dependencies to have aversionfield — the backport included the git spec but dropped
version = "0.6".Proposal
Add
version = "0.6"to thetikv-jemallocatorworkspace dependency, matching what#5602 has on
main. The[patch.crates-io]section still ensures the git fork is usedat build time; the version is only needed so
cargo packageknows what to referencewhen
stripping git specs for packaging.
Also temporarily adds a
pull_requesttrigger to the Documentation workflow so the fixcan be verified on this PR before merging. This trigger should be removed before or
after merge.
Test Plan
test-crates-and-docrsjob will run on this PR via the temporary trigger