Backport to testnet_conway: Arc deeper through certificate/block paths + Arc newtype (#6147 + #6330)#6331
Closed
ndr-ds wants to merge 1 commit into
Closed
Backport to testnet_conway: Arc deeper through certificate/block paths + Arc newtype (#6147 + #6330)#6331ndr-ds wants to merge 1 commit into
ndr-ds wants to merge 1 commit into
Conversation
…s + linera_cache::Arc<T> newtype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Supersedes #6249 (which had accumulated merge conflicts). Backports #6147 and #6330 to
testnet_conwayin a single commit on a rebased branch.Proposal
Cherry-pick of #6147 rebased on current
testnet_conwaytip, with conflict resolution, plus thelinera_cache::Arc<T>newtype from #6330.Conflict resolution notes:
linera-storage/src/lib.rs: took testnet_conway's removals (shared_committees,get_or_load_committee_by_hash,committee_for_epoch, test module); adjustedget_or_load_committeereturn type tostd::sync::Arc<Committee>(Committee is not managed by value cache)linera-storage/src/db_storage.rs: took testnet_conway's structure throughout, then applied newtype return-type changeslinera-core/src/client/chain_client/mod.rs: kept testnet_conway'sdownload_certificates_for_eventsrestructuring andBlobsNotFoundhandling; adapted blob/certificate boundary conversions (into_std(),as_std().clone())linera-service/src/proxy/grpc.rs: kept testnet_conway'sif all_foundguard; used(&*certificate).into()to avoid.as_ref()ambiguity onCacheArcTest Plan
CI —
cargo check --workspace --exclude linera-webandcargo clippyclean locally before pushing.Release Plan
Links
linera_cache::Arc<T>newtype enforcing one-allocation-per-content invariant #6330 — the newtype follow-up on main