ci: register linera-tests in the IMAGE_VAR loop#6353
Merged
Conversation
#6349 added the LineraTests build/push call and its PID handling but omitted the `LINERA_TESTS:linera-tests` entry in the loop that populates the `<VAR>_IMAGE_{BRANCH,SHORT,LONG}` env vars. As a result the build step receives empty `-t ""` flags and docker rejects them with "invalid tag \"\": repository name must have at least one component", failing the LineraTests sub-build while the four production images still build and push normally. One-liner fix: add the missing entry. Verified locally by re-rendering the env-vars step in a shell with the same loop and confirming all three LINERA_TESTS_IMAGE_* values resolve to the expected GAR URI. Refs: linera-io/linera-infra#1188
eldios
added a commit
that referenced
this pull request
May 21, 2026
## Summary One-liner fix to #6350: that PR added the LineraTests `build_and_push` call and its PID handling but omitted the `LINERA_TESTS:linera-tests` entry in the `for IMAGE_VAR in …` loop that populates the `<VAR>_IMAGE_{BRANCH,SHORT,LONG}` env vars. As a result the LineraTests sub-build receives empty `-t \"\"` flags and docker rejects them with: ``` ERROR: failed to build: invalid tag "": repository name must have at least one component ``` The four production images (`linera`, `linera-indexer`, `linera-explorer`, `linera-exporter`) built and pushed normally on the #6350 merge run — only `linera-tests` failed. See linera-io/linera-protocol/actions/runs/26200303794. Same fix is going up against `main` as #6353. Once this lands the next push to `testnet_conway` triggers a clean run and `linera-tests:testnet_conway` appears in the registry alongside the existing tags, unblocking linera-io/linera-infra#1191. Refs: linera-io/linera-infra#1188 ## Test plan - Verified locally by re-rendering the env-vars step with the patched loop in a shell and confirming all three `LINERA_TESTS_IMAGE_*` values resolve to the expected `us-docker.pkg.dev/linera-io-dev/linera-public-registry/linera-tests:<tag>` URIs. - Real validation happens at merge time: the `Docker Image` workflow re-fires on `testnet_conway` and either pushes a `linera-tests:testnet_conway` (and short/long sha) tag, or fails differently — at which point we'll know the loop fix was sufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
One-liner fix to #6349: that PR added the LineraTests
build_and_pushcall and its PID handling but omitted theLINERA_TESTS:linera-testsentry in thefor IMAGE_VAR in …loop that populates the<VAR>_IMAGE_{BRANCH,SHORT,LONG}env vars. As a result the LineraTests sub-build receives empty-t \"\"flags and docker rejects them with:The four production images (
linera,linera-indexer,linera-explorer,linera-exporter) build and push normally — onlylinera-testsfails. Verified on thetestnet_conwayrun that fired on the #6350 merge (linera-io/linera-protocol/actions/runs/26200303794).Same fix is going up against
testnet_conwayas #6354 so the dailynetwork-health-checkCronJob (linera-infra) can finally find thelinera-tests:testnet_conway_releasetag.Refs: linera-io/linera-infra#1188
Test plan
LINERA_TESTS_IMAGE_*values resolve to the expectedus-docker.pkg.dev/linera-io-dev/linera-public-registry/linera-tests:<tag>URIs.Docker Imageworkflow re-fires onmainand either pushes alinera-tests:main(and short/long sha) tag, or fails differently — at which point we'll know the loop fix was sufficient.