Commit bd924c4
docs(linux): correct version-tagged comments with actual upstream history
Three comments in src/cefpython.pyx and src/window_info.pyx carried
"CEF 123+" or "CEF 146+" attributions that were imprecise (added by
the user during cefpython 123/146 bring-up rather than reflecting an
actual upstream behavior change at those versions). Replaced each
with a comment grounded in the real upstream commit and the actual
mechanism observed.
- CreateBrowserSync: CefCurrentlyOn(TID_UI) comment — the public API
has always returned false + LOG(WARNING) when no task runner is
registered (libcef/common/task_impl.cc:13). Drop the "CEF 146+" tag
and explain why cefpython's defer-until-OnContextInitialized flow
reaches this code before BrowserThread::UI is established.
- CreateBrowserSync: OnContextInitialized defer comment — the wait
requirement comes from CEF commit 691c9c2 ("Wait for
CefBrowserContext initialization", 2021-04-14, issue #2969), not
CEF 123. Symptom is the renderer's first IPC message
(blink.mojom.WidgetHost) being rejected before host bindings are
wired. Strategy section now documents that Linux skips the manual
pump deliberately to keep Initialize() non-blocking — empirical
testing on current cefpython shows the pump *does* fire
OnContextInitialized in 2-3s on both Ozone X11 and Wayland, so the
historical "needs gtk_main()" claim is no longer accurate, but we
still skip to avoid the latency.
- window_info.pyx: drop the four duplicate
"# CEF 123+: must request Alloy runtime" lines and consolidate into
one function-level note in SetCefWindowInfo. The runtime_style
field on cef_window_info_t actually arrived in CEF commit dca0435d2
("chrome: Add support for Alloy style browsers and windows", issue
#3681, 2024-04-17), first shipping in CEF branch 6422
(~Chromium 125, May 2024) — well after CEF 123, where the field
did not exist. The note also explains why Alloy style is required:
chrome bootstrap default (since branch 6478) makes windowed parent
windows default to Chrome style, which can't be parented via
SetAsChild and would change the callback model.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>1 parent db13d7d commit bd924c4
2 files changed
Lines changed: 60 additions & 14 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
676 | 676 | | |
677 | 677 | | |
678 | 678 | | |
679 | | - | |
680 | | - | |
681 | | - | |
682 | | - | |
683 | | - | |
684 | | - | |
| 679 | + | |
| 680 | + | |
| 681 | + | |
| 682 | + | |
| 683 | + | |
| 684 | + | |
| 685 | + | |
| 686 | + | |
| 687 | + | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
685 | 691 | | |
686 | 692 | | |
687 | 693 | | |
| |||
731 | 737 | | |
732 | 738 | | |
733 | 739 | | |
734 | | - | |
735 | | - | |
736 | | - | |
737 | | - | |
738 | | - | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
| 746 | + | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
| 750 | + | |
| 751 | + | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
| 755 | + | |
| 756 | + | |
| 757 | + | |
| 758 | + | |
| 759 | + | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
| 764 | + | |
| 765 | + | |
| 766 | + | |
| 767 | + | |
739 | 768 | | |
740 | 769 | | |
741 | 770 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
11 | 31 | | |
12 | 32 | | |
13 | 33 | | |
| |||
42 | 62 | | |
43 | 63 | | |
44 | 64 | | |
45 | | - | |
46 | 65 | | |
47 | 66 | | |
48 | 67 | | |
| |||
63 | 82 | | |
64 | 83 | | |
65 | 84 | | |
66 | | - | |
67 | 85 | | |
68 | 86 | | |
69 | 87 | | |
| |||
73 | 91 | | |
74 | 92 | | |
75 | 93 | | |
76 | | - | |
77 | 94 | | |
78 | 95 | | |
79 | 96 | | |
| |||
0 commit comments