Commit 217e6cf
committed
fix: treat negative Limit/Page/Offset values as zero
Fixes gogf#4699
## Changes
- `Limit()`: Convert negative values to 0 for both start and limit parameters
- `Page()`: Convert negative limit values to 0 (returns empty result)
- `Offset()`: Convert negative offsets to 0
## Behavior
- `Limit(-1)` → `LIMIT 0` (returns empty result)
- `Page(1, -10)` → `LIMIT 0` (returns empty result)
- `Offset(-5)` → `OFFSET 0` (equivalent to no offset)
This approach maintains API friendliness by avoiding errors while
ensuring SQL validity across all database drivers.
## Tests
- Added `Test_Issue4699` in `gdb_z_unit_issue_test.go` covering:
- Single/dual parameter Limit with negative values
- Page with negative limit parameter
- Offset with negative value
- Mixed positive/negative parameter combinations1 parent c8a11f7 commit 217e6cf
2 files changed
Lines changed: 72 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
615 | 615 | | |
616 | 616 | | |
617 | 617 | | |
| 618 | + | |
618 | 619 | | |
619 | 620 | | |
620 | 621 | | |
621 | 622 | | |
| 623 | + | |
| 624 | + | |
| 625 | + | |
622 | 626 | | |
623 | 627 | | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
624 | 634 | | |
625 | 635 | | |
626 | 636 | | |
| |||
629 | 639 | | |
630 | 640 | | |
631 | 641 | | |
| 642 | + | |
632 | 643 | | |
633 | 644 | | |
| 645 | + | |
| 646 | + | |
| 647 | + | |
634 | 648 | | |
635 | 649 | | |
636 | 650 | | |
| |||
645 | 659 | | |
646 | 660 | | |
647 | 661 | | |
| 662 | + | |
648 | 663 | | |
649 | 664 | | |
650 | 665 | | |
651 | 666 | | |
652 | 667 | | |
| 668 | + | |
| 669 | + | |
| 670 | + | |
653 | 671 | | |
654 | 672 | | |
655 | 673 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
0 commit comments