Commit 3ed3423
committed
fix(pgsql): fix 5 bugs found during code review
1. Test_PgSQL_JSONB_Existence: replace `data ? 'email'` with
`jsonb_exists(data, 'email')` — bare `?` gets mangled by DoFilter
into a $N placeholder, breaking the query.
2. Test_Issue2787: fix SQL condition assertions from MySQL backtick
quoting (`id`) to PgSQL double-quote quoting ("id").
3. Test_Issue3671: fix copy-paste table name prefix from "issue3632"
to "issue3671".
4. issue1412.sql: add DROP TABLE IF EXISTS guards for "parcels" and
"items" to prevent CREATE TABLE failures when tests share a process.
5. Test_Issue2643: replace unjustified Skip with actual PgSQL test —
lpad, concat_ws, replace, CASE WHEN are all standard PgSQL functions.
Adapted quoting from backticks to double-quotes and added `::text`
cast for lpad (PgSQL requires text input).
ref gogf#46891 parent 6a7d7c3 commit 3ed3423
4 files changed
Lines changed: 47 additions & 7 deletions
File tree
- contrib/drivers/pgsql
- testdata/issues
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
113 | 113 | | |
114 | 114 | | |
115 | 115 | | |
116 | | - | |
| 116 | + | |
| 117 | + | |
117 | 118 | | |
118 | | - | |
| 119 | + | |
119 | 120 | | |
120 | 121 | | |
121 | 122 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
126 | 126 | | |
127 | 127 | | |
128 | 128 | | |
129 | | - | |
| 129 | + | |
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
| |||
1154 | 1154 | | |
1155 | 1155 | | |
1156 | 1156 | | |
1157 | | - | |
| 1157 | + | |
1158 | 1158 | | |
1159 | 1159 | | |
1160 | 1160 | | |
| |||
1163 | 1163 | | |
1164 | 1164 | | |
1165 | 1165 | | |
1166 | | - | |
| 1166 | + | |
1167 | 1167 | | |
1168 | 1168 | | |
1169 | 1169 | | |
| |||
1172 | 1172 | | |
1173 | 1173 | | |
1174 | 1174 | | |
1175 | | - | |
| 1175 | + | |
1176 | 1176 | | |
1177 | 1177 | | |
1178 | 1178 | | |
| |||
1473 | 1473 | | |
1474 | 1474 | | |
1475 | 1475 | | |
1476 | | - | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
| 1484 | + | |
| 1485 | + | |
| 1486 | + | |
| 1487 | + | |
| 1488 | + | |
| 1489 | + | |
| 1490 | + | |
| 1491 | + | |
| 1492 | + | |
| 1493 | + | |
| 1494 | + | |
| 1495 | + | |
| 1496 | + | |
| 1497 | + | |
| 1498 | + | |
| 1499 | + | |
| 1500 | + | |
| 1501 | + | |
| 1502 | + | |
| 1503 | + | |
| 1504 | + | |
| 1505 | + | |
1477 | 1506 | | |
1478 | 1507 | | |
1479 | 1508 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
1 | 4 | | |
2 | 5 | | |
3 | 6 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
0 commit comments