Skip to content

Commit 4093695

Browse files
committed
refactor: remove misleading comments about SET search_path
Remove notes about "SET search_path is session-specific" from test comments since these tests use explicit schema parameter or schema- qualified table names, not SET search_path SQL command.
1 parent f2e8832 commit 4093695

2 files changed

Lines changed: 2 additions & 10 deletions

File tree

contrib/drivers/gaussdb/gaussdb_z_unit_issue_test.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ import (
1818

1919
// https://github.com/gogf/gf/issues/4495
2020
// Test Tables() returns tables from specific schema using explicit schema parameter.
21-
// Note: SET search_path is session-specific and doesn't work reliably with connection pooling.
22-
// The recommended approach is to use db.Tables(ctx, schema) with explicit schema parameter.
2321
func Test_Issue4495_Tables_SearchPath(t *testing.T) {
2422
var (
2523
schema1 = fmt.Sprintf("test_schema1_%d", gtime.TimestampNano())
@@ -89,9 +87,7 @@ func Test_Issue4495_Tables_SearchPath(t *testing.T) {
8987

9088
// https://github.com/gogf/gf/issues/4495
9189
// Test TableFields() returns correct field info for same-name tables in different schemas
92-
// using schema-qualified table names.
93-
// Note: SET search_path is session-specific and doesn't work reliably with connection pooling.
94-
// The recommended approach is to use schema-qualified table names like "schema.table".
90+
// using schema-qualified table names like "schema.table".
9591
func Test_Issue4495_TableFields_SchemaFilter(t *testing.T) {
9692
var (
9793
schema1 = fmt.Sprintf("test_schema1_%d", gtime.TimestampNano())

contrib/drivers/pgsql/pgsql_z_unit_issue_test.go

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -294,8 +294,6 @@ func Test_Issue4500(t *testing.T) {
294294

295295
// https://github.com/gogf/gf/issues/4495
296296
// Test Tables() returns tables from specific schema using explicit schema parameter.
297-
// Note: SET search_path is session-specific and doesn't work reliably with connection pooling.
298-
// The recommended approach is to use db.Tables(ctx, schema) with explicit schema parameter.
299297
func Test_Issue4495_Tables_SearchPath(t *testing.T) {
300298
var (
301299
schema1 = fmt.Sprintf("test_schema1_%d", gtime.TimestampNano())
@@ -365,9 +363,7 @@ func Test_Issue4495_Tables_SearchPath(t *testing.T) {
365363

366364
// https://github.com/gogf/gf/issues/4495
367365
// Test TableFields() returns correct field info for same-name tables in different schemas
368-
// using schema-qualified table names.
369-
// Note: SET search_path is session-specific and doesn't work reliably with connection pooling.
370-
// The recommended approach is to use schema-qualified table names like "schema.table".
366+
// using schema-qualified table names like "schema.table".
371367
func Test_Issue4495_TableFields_SchemaFilter(t *testing.T) {
372368
var (
373369
schema1 = fmt.Sprintf("test_schema1_%d", gtime.TimestampNano())

0 commit comments

Comments
 (0)