Skip to content

Commit ceb1bbe

Browse files
committed
fix(pgsql): use "1=1" instead of integer 1 in Test_TX_Delete condition
PostgreSQL does not accept `WHERE 1` (integer as boolean condition). MySQL auto-casts `1` to true, but PgSQL requires an explicit boolean expression. Use `"1=1"` which is valid standard SQL across all dialects. ref gogf#4689
1 parent c9fb0cd commit ceb1bbe

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

contrib/drivers/pgsql/pgsql_z_unit_transaction_test.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1697,7 +1697,8 @@ func Test_TX_Delete(t *testing.T) {
16971697
tx, err := db.Begin(ctx)
16981698
t.AssertNil(err)
16991699

1700-
_, err = tx.Delete(table, 1)
1700+
// PgSQL does not accept "WHERE 1" (integer as boolean); use "1=1" instead.
1701+
_, err = tx.Delete(table, "1=1")
17011702
t.AssertNil(err)
17021703

17031704
err = tx.Commit()
@@ -1716,7 +1717,8 @@ func Test_TX_Delete(t *testing.T) {
17161717
tx, err := db.Begin(ctx)
17171718
t.AssertNil(err)
17181719

1719-
_, err = tx.Delete(table, 1)
1720+
// PgSQL does not accept "WHERE 1" (integer as boolean); use "1=1" instead.
1721+
_, err = tx.Delete(table, "1=1")
17201722
t.AssertNil(err)
17211723

17221724
n, err := tx.Model(table).Count()

0 commit comments

Comments
 (0)