fix(test): make cni-repair-controller test more resilient#775
Merged
Conversation
The test was failing when deploying the pause DS and immediately checking for its readiness, as the kube-api didn't have time to acknowledge the existence of that workload. Added a loop around that, as well as homogenizing the last for loop checking for DS replica replacement.
raykroeker
reviewed
Jun 30, 2026
raykroeker
left a comment
raykroeker
left a comment
Contributor
There was a problem hiding this comment.
If the pause-app never meets the ready condition, what if anything times out the wait loops?
Member
Author
The repair-controller job has a timeout of 15m |
raykroeker
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was failing when deploying the pause DS and immediately checking for its readiness, as the kube-api didn't have time to acknowledge the existence of that workload. Added a loop around that, as well as homogenizing the last for loop checking for DS replica replacement.