Resolve ambiguity on how to handle attributes#259
Open
Silvanoc wants to merge 1 commit into
Open
Conversation
This patch fixes the `attributes` specification for more clarity on how to handle `attributes` converting to other formats. Before this patch the `attributes` specification had a comment that gave the impression that `attributes` are only syntactic sugar for class-scoped slots (slots that are only available to be used by a class and its descendants) and specifying the conversion of `attributes` into `slots` renaming them to `<class-name>__<attribute-name>`. This patch modifies that comment so that `attributes` are kept as 1st-class-citizens even on conversions. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the
attributesspecification for more clarity on how to handleattributesconverting to other formats.Before this patch the
attributesspecification had a comment that gave the impression thatattributesare only syntactic sugar for class-scoped slots (slots that are only available to be used by a class and its descendants) and specifying the conversion ofattributesintoslotsrenaming them to<class-name>__<attribute-name>.This patch modifies that comment so that
attributesare kept as 1st-class-citizens even on conversions.Fixes: linkml/linkml#3669