feat(openenum): add is_open boolean slot to enum expressions#261
feat(openenum): add is_open boolean slot to enum expressions#261noelmcloughlin wants to merge 1 commit into
Conversation
4d688c8 to
19a714c
Compare
|
The basic idea makes total sense to me. I just wonder if we want to have a single way of declaring this across the few places we want similar behavior - e.g.
Basically I am in favor of this but just wondering if we want to have a similar mechanism/pattern across all "openness" specs, or if there is a reason this one should be a boolean only |
|
I am just now thinking maybe But issue linkml/linkml#127 proposes 'open enums' via I noted linkml/linkml#1595 discusses |
|
This has been a general naming tension between how I normally think and how linkml does names - I generally tend towards more general names whose meaning varies by context, and linkml tends to have specific names and only use them in one or a few contexts in which is has a single meaning. So where I would probably gravitate towards a single
But anyway, need to decide if we want to have common mechanism/pattern for declaring "all/none/some" openness, or if sometimes binary and sometimes trinary is fine. That also narrows down which names work. |
|
As this issue is slightly beyond my current ability to judge, @amc-corey-cox has volunteered to thinking through the implications and presenting a short version of this at the next developer call in one week. Sorry for the delay - please keep pushing if we slow you down; I can find more aggressive alternative review processes. 🚀 |
This PR adds
is_openboolean slot to enum expressions in the meta model.See linkml/linkml#127 and linkml/linkml#3712