fix: status's range is string instead of uriorcurie#263
Open
Silvanoc wants to merge 1 commit into
Open
Conversation
The slot `status` declares it's range to be `string`, but in fact bare strings like `testing` or `unstable` are being used in the metamodel itself. This patch aligns the specification with its current use. Fixing it to remain `uriorcurie` would require multiple changes with bigger impact than this change. They might get implemented in the future. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
Silvanoc
force-pushed
the
fix-status-slot
branch
from
349ff31 to
6235d1f
Compare
matentzn
reviewed
Jul 15, 2026
matentzn
left a comment
matentzn
left a comment
Contributor
There was a problem hiding this comment.
@Silvanoc can you redo the PR with just the model changes? I will do the generation of files on a slightly different cadance (it also makes it clearer which files have actially changed other than linkml_model/model/schema/meta.yaml)
Author
@matentzn sure! Guess why I have two commits with exactly that split 😉 I'll drop the 2nd one and done. |
Silvanoc
force-pushed
the
fix-status-slot
branch
from
6235d1f to
3722be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The slot
statusdeclares it's range to bestring, but in fact bare strings liketestingorunstableare being used in the metamodel itself (more details in the below linked issue). This patch aligns the specification with its current use.Fixing it to remain
uriorcuriewould require multiple changes with bigger impact than this change. They might get implemented in the future.Fixes: linkml/linkml#3760