Remove this inner class, when Disposable class start support AllowMultipleDisposeCalls value overriding

[konard]

Data.Doublets/Platform.Data.Doublets/Decorators/LinksDisposableDecoratorBase.cs

Lines 11 to 21 in d047063

	protected class DisposableWithMultipleCallsAllowed : Disposable
	{
	[MethodImpl(MethodImplOptions.AggressiveInlining)]
	public DisposableWithMultipleCallsAllowed(Disposal disposal) : base(disposal) { }
	protected override bool AllowMultipleDisposeCalls
	{
	[MethodImpl(MethodImplOptions.AggressiveInlining)]
	get => true;
	}
	}

This issue can be closed as soon as linksplatform/Disposables#35 issue is fixed.

[konard]

After investigation, the referenced issue linksplatform/Disposables#35 is still open and unresolved. The Disposable class in Platform.Disposables package does not yet have a constructor that allows overriding the AllowMultipleDisposeCalls property.

Therefore, the DisposableWithMultipleCallsAllowed inner class in LinksDisposableDecoratorBase.cs is still necessary as a workaround and should NOT be removed at this time.

This issue should remain open until the upstream dependency issue is resolved.

[konard]

🔍 Investigation Update (October 2025)

I've completed a thorough investigation of this issue and its upstream dependency. Here's the current status:

Summary

Good news: A complete solution exists in the upstream repository!
Challenge: It hasn't been merged or released yet.

---

🔎 Findings

Current State:

• The workaround inner class DisposableWithMultipleCallsAllowed in LinksDisposableDecoratorBase.cs is still necessary
• This repository currently uses Platform.Disposables version 0.4.0 (released December 2022)
• The latest NuGet version (0.4.0) does NOT include constructor-based override capability

Upstream Solution:

• ✅ Issue Use group expression instead #35 in the Disposables repository has a ready-to-merge solution: PR #95
• ✅ PR #95 includes the exact feature requested: constructor parameters for allowMultipleDisposeCalls
• ✅ All tests pass (11/11)
• ✅ Fully backward compatible
• ❌ But: PR #95 is still open and not yet merged (created Sept 14, 2025)

---

⏳ What Needs to Happen

This issue is blocked by upstream and cannot be resolved until:

1. Upstream (Platform.Disposables):

   • PR #95 gets reviewed and merged
   • New version (e.g., 0.5.0) is released to NuGet

2. Then this repository can:

   • Update to new Platform.Disposables version
   • Remove the DisposableWithMultipleCallsAllowed inner class
   • Use the new constructor: new Disposable(disposal, allowMultipleDisposeCalls: true)

---

📋 Recommendation

This issue should remain open until:

• Platform.Disposables PR #95 is merged: Add constructor overloads to override AllowMultipleDisposeCalls and AllowMultipleDisposeAttempts Disposables#95
• A new version with the feature is published to NuGet
• This repository updates its dependency and removes the workaround

---

📚 References

• Detailed investigation report: PR #509
• Upstream issue: Add constructor that can override values of AllowMultipleDisposeCalls and AllowMultipleDisposeAttempts properties Disposables#35
• Upstream solution (pending merge): Add constructor overloads to override AllowMultipleDisposeCalls and AllowMultipleDisposeAttempts Disposables#95
• Current NuGet version: https://www.nuget.org/packages/Platform.Disposables/ (0.4.0)

I'll continue to monitor the upstream PR status and can implement the changes here as soon as the dependency is updated.