Add optional automatic gaps filling feature for append-only databases#476
Open
konard wants to merge 3 commits into
Open
Add optional automatic gaps filling feature for append-only databases#476konard wants to merge 3 commits into
konard wants to merge 3 commits into
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #172
For databases that do not delete data (all changes archived), the automatic gaps filling feature can now be disabled to improve performance by skipping runtime existence checks during link iteration. Changes: - Add _enableAutomaticGapsFilling field to UnitedMemoryLinksBase - Add new constructor overloads to support the enableAutomaticGapsFilling parameter - Modify Each method to conditionally skip Exists checks when gaps filling is disabled - Add comprehensive tests for both enabled and disabled modes This addresses the performance concern raised in issue #172 for append-only database scenarios. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the solution for issue #172 by adding an optional automatic gaps filling feature that can be disabled for databases that do not delete data (all changes archived).
Changes Made:
_enableAutomaticGapsFillingfield toUnitedMemoryLinksBaseto control runtime existence checksUnitedMemoryLinksBaseandUnitedMemoryLinksto accept theenableAutomaticGapsFillingparameterEachmethod to conditionally skipExists()checks when gaps filling is disabledPerformance Benefits:
For append-only databases (databases that never delete data), disabling automatic gaps filling eliminates runtime
Exists()checks, improving performance during link iteration.API Usage:
Test Plan:
AutomaticGapsFillingDisabledTestto verify skip behaviorAutomaticGapsFillingEnabledTestto verify default behaviorThis implementation maintains full backward compatibility while providing the requested performance optimization for append-only database scenarios.
🤖 Generated with Claude Code
Resolves #172