Enable external references by default in all memory adapters#482
Open
konard wants to merge 3 commits into
Open
Enable external references by default in all memory adapters#482konard wants to merge 3 commits into
konard wants to merge 3 commits into
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #155
This change addresses issue #155 by enabling external references support by default in all memory adapter classes. The following changes were made: - Updated SplitMemoryLinksBase, SplitMemoryLinks, UnitedMemoryLinks, UnitedMemoryLinksBase, and Link classes to use LinksConstants with enableExternalReferencesSupport: true instead of Default instance - Updated ResizableDirectMemoryLinksTests to use consistent constants - All tests pass with the new default configuration The change provides better out-of-the-box functionality for users who need external references support, which is now the default behavior. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #155 by enabling external references support by default in all memory adapter classes.
SplitMemoryLinksBaseto enable external references by defaultSplitMemoryLinksto enable external references by defaultUnitedMemoryLinksto enable external references by defaultUnitedMemoryLinksBaseto enable external references by defaultLinkclass to enable external references by defaultChanges Made
Instead of using
Default<LinksConstants<TLinkAddress>>.Instance(which disables external references), all memory adapters now usenew LinksConstants<TLinkAddress>(enableExternalReferencesSupport: true)as their default configuration.This provides better out-of-the-box functionality for users who need external references support, which is now the default behavior across all memory adapters.
Test Plan
Closes #155
🤖 Generated with Claude Code