Replace direct comparisons with TargetMatcher and SourceMatcher#483
Open
konard wants to merge 3 commits into
Open
Replace direct comparisons with TargetMatcher and SourceMatcher#483konard wants to merge 3 commits into
konard wants to merge 3 commits into
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #153
- Create SourceMatcher class following the same pattern as TargetMatcher - Update CountUsages method to use SourceMatcher and TargetMatcher instead of direct comparisons - Update Equals method to use criterion matchers for source and target matching - Add comprehensive tests for both matchers and updated functionality This addresses issue #153 by using TargetMatcher (and newly created SourceMatcher) instead of direct GetTarget/GetSource comparisons in critical methods. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #153 by replacing direct
GetTargetandGetSourcecomparisons with the appropriate criterion matchers (TargetMatcherandSourceMatcher).Changes Made
✅ Created SourceMatcher class
SourceMatcher<TLinkAddress>following the same pattern asTargetMatcherICriterionMatcher<TLinkAddress>interface✅ Updated ILinksExtensions methods
CountUsagesmethod to useSourceMatcherandTargetMatcherinstead of direct comparisonsEqualsmethod to use criterion matchers for source and target validationPlatform.Data.Doublets.CriterionMatchers✅ Comprehensive test coverage
CriterionMatchersTestswith full test suiteTargetMatcherandSourceMatcherfunctionalityCountUsagesandEqualsmethodsTest Results
Technical Details
Resolves
Fixes #153
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com