Use Range.Positive property instead of hardcoded tuple#484
Open
konard wants to merge 4 commits into
Open
Conversation
Adding CLAUDE.md with task information for AI processing. This file will be removed when the task is complete. Issue: #152
- Replaced (1, long.MaxValue) tuple with explicit Range<ulong> object - Added Platform.Ranges using statement - Created PositiveInt64 constant representing [1, long.MaxValue] range - Added TODO comment to replace with Range.PositiveInt64 when available - Maintains identical functionality while improving code semantics Resolves #152 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
konard
changed the title
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces hardcoded tuple
(1, long.MaxValue)with semanticRange.PositiveInt64constant in LinksConstantsTests.Changes Made
(1, long.MaxValue)to explicitRange<ulong>objectPositiveInt64representing the range[1, long.MaxValue]Range.PositiveInt64property when available in Platform.RangesTechnical Details
The original code used implicit conversion from tuple to
Range<ulong>in the LinksConstants constructor. This change makes the semantic intent explicit while maintaining identical functionality.Before:
After:
Testing
ExternalReferencesTestverifiedAddresses Issue
Resolves #152 - Use Range.Positive property here
This change prepares the codebase for the future
Range.PositiveInt64property requested in linksplatform/Ranges#30🤖 Generated with Claude Code