Merge pull request #111 from linksplatform/issue-106-48d2da31

konard · web-flow · commit b28480c4dc0e · 2026-04-14T19:11:02.000+05:30
Replace hardcoded bit sizes with named constants in Bit&lt;T&gt; methods
diff --git a/cpp/Platform.Numbers/Bit.h b/cpp/Platform.Numbers/Bit.h
@@ -59,11 +59,11 @@ namespace Platform::Numbers::Bit
     {
         if (shift < 0)
         {
-            shift = sizeof(T) * 8 + shift;
+            shift = sizeof(T) * std::numeric_limits<unsigned char>::digits + shift;
         }
         if (limit < 0)
         {
-            limit = sizeof(T) * 8 + limit;
+            limit = sizeof(T) * std::numeric_limits<unsigned char>::digits + limit;
         }
         auto sourceMask = ~(std::numeric_limits<T>::max() << limit) & std::numeric_limits<T>::max();
         auto targetMask = ~(sourceMask << shift);
@@ -75,11 +75,11 @@ namespace Platform::Numbers::Bit
     {
         if (shift < 0)
         {
-            shift = sizeof(T) * 8 + shift;
+            shift = sizeof(T) * std::numeric_limits<unsigned char>::digits + shift;
         }
         if (limit < 0)
         {
-            limit = sizeof(T) * 8 + limit;
+            limit = sizeof(T) * std::numeric_limits<unsigned char>::digits + limit;
         }
         auto sourceMask = ~(std::numeric_limits<T>::max() << limit) & std::numeric_limits<T>::max();
         auto targetMask = sourceMask << shift;

Original file line number	Diff line number	Diff line change
`@@ -59,11 +59,11 @@ namespace Platform::Numbers::Bit`
`59`	`59`	`{`
`60`	`60`	`if (shift < 0)`
`61`	`61`	`{`
`62`		`- shift = sizeof(T) * 8 + shift;`
	`62`	`+ shift = sizeof(T) * std::numeric_limits<unsigned char>::digits + shift;`
`63`	`63`	`}`
`64`	`64`	`if (limit < 0)`
`65`	`65`	`{`
`66`		`- limit = sizeof(T) * 8 + limit;`
	`66`	`+ limit = sizeof(T) * std::numeric_limits<unsigned char>::digits + limit;`
`67`	`67`	`}`
`68`	`68`	`auto sourceMask = ~(std::numeric_limits<T>::max() << limit) & std::numeric_limits<T>::max();`
`69`	`69`	`auto targetMask = ~(sourceMask << shift);`
`@@ -75,11 +75,11 @@ namespace Platform::Numbers::Bit`
`75`	`75`	`{`
`76`	`76`	`if (shift < 0)`
`77`	`77`	`{`
`78`		`- shift = sizeof(T) * 8 + shift;`
	`78`	`+ shift = sizeof(T) * std::numeric_limits<unsigned char>::digits + shift;`
`79`	`79`	`}`
`80`	`80`	`if (limit < 0)`
`81`	`81`	`{`
`82`		`- limit = sizeof(T) * 8 + limit;`
	`82`	`+ limit = sizeof(T) * std::numeric_limits<unsigned char>::digits + limit;`
`83`	`83`	`}`
`84`	`84`	`auto sourceMask = ~(std::numeric_limits<T>::max() << limit) & std::numeric_limits<T>::max();`
`85`	`85`	`auto targetMask = sourceMask << shift;`