feat: parse Team Service status

Author: j-zimnowoda

src/k8s-operations.test.ts

@@ -184,13 +184,28 @@ const makeServiceResponse = (name: string, teamName: string, overrides: Record<s
     ...overrides,
   }) as unknown as AplServiceResponse
 
-const makeHTTPRoute = (conditions: { type: string; status: string }[]) => ({
+const makeHTTPRoute = (
+  conditions: { type: string; status: string }[],
+  options: { parentGatewayName?: string; visibility?: string } = {},
+) => ({
+  metadata: {
+    labels: {
+      'networking.knative.dev/visibility': options.visibility ?? '',
+    },
+  },
+  spec: {
+    parentRefs: [{ name: options.parentGatewayName ?? 'platform' }],
+  },
   status: {
     parents: [
       {
         conditions,
         controllerName: 'istio.io/gateway-controller',
-        parentRef: { group: 'gateway.networking.k8s.io', kind: 'Gateway', name: 'knative-local-gateway' },
+        parentRef: {
+          group: 'gateway.networking.k8s.io',
+          kind: 'Gateway',
+          name: options.parentGatewayName ?? 'platform',
+        },
       },
     ],
   },
@@ -252,6 +267,20 @@ describe('getServiceStatus', () => {
     expect(result).toBe('NotFound')
   })
 
+  test('returns NotFound when only local HTTPRoutes exist', async () => {
+    mockList([
+      makeHTTPRoute(
+        [
+          { type: 'Accepted', status: 'True' },
+          { type: 'ResolvedRefs', status: 'True' },
+        ],
+        { parentGatewayName: 'knative-local-gateway', visibility: 'cluster-local' },
+      ),
+    ])
+    const result = await getServiceStatus(makeServiceResponse('web', 'alpha'))
+    expect(result).toBe('NotFound')
+  })
+
   test('returns Unknown when multiple HTTPRoutes are found', async () => {
     mockList([makeHTTPRoute([]), makeHTTPRoute([])])
     const result = await getServiceStatus(makeServiceResponse('web', 'alpha'))
@@ -269,6 +298,24 @@ describe('getServiceStatus', () => {
     expect(result).toBe('Succeeded')
   })
 
+  test('returns Succeeded when local and public routes exist and public is accepted', async () => {
+    mockList([
+      makeHTTPRoute(
+        [
+          { type: 'Accepted', status: 'True' },
+          { type: 'ResolvedRefs', status: 'True' },
+        ],
+        { parentGatewayName: 'knative-local-gateway', visibility: 'cluster-local' },
+      ),
+      makeHTTPRoute([
+        { type: 'Accepted', status: 'True' },
+        { type: 'ResolvedRefs', status: 'True' },
+      ]),
+    ])
+    const result = await getServiceStatus(makeServiceResponse('web', 'alpha'))
+    expect(result).toBe('Succeeded')
+  })
+
   test('returns Unknown when single HTTPRoute is not accepted', async () => {
     mockList([
       makeHTTPRoute([

src/k8s-operations.ts

@@ -243,6 +243,15 @@ export function parseHTTPRouteStatus(httpRoute: any): boolean {
   return isAccepted
 }
 
+function isPublicHTTPRoute(httpRoute: any): boolean {
+  const visibility = httpRoute?.metadata?.labels?.['networking.knative.dev/visibility']
+  if (visibility === 'cluster-local') return false
+
+  const parentRefs: any[] = Array.isArray(httpRoute?.spec?.parentRefs) ? httpRoute.spec.parentRefs : []
+  const hasLocalGateway = parentRefs.some((parentRef) => parentRef?.name === 'knative-local-gateway')
+  return !hasLocalGateway
+}
+
 export async function getServiceStatus(service: AplServiceResponse): Promise<'Succeeded' | 'Unknown' | 'NotFound'> {
   const { name, labels } = service.metadata
   const teamName = labels['apl.io/teamId']
@@ -257,18 +266,19 @@ export async function getServiceStatus(service: AplServiceResponse): Promise<'Su
   )
 
   const httpRoutes = Array.isArray(res?.items) ? res.items : []
+  const publicHttpRoutes = httpRoutes.filter((httpRoute) => isPublicHTTPRoute(httpRoute))
 
-  if (httpRoutes.length === 0) {
-    debug(`No HTTPRoutes found for service ${name} in namespace ${namespace}.`)
+  if (publicHttpRoutes.length === 0) {
+    debug(`No public HTTPRoutes found for service ${name} in namespace ${namespace}.`)
     return 'NotFound'
-  } else if (httpRoutes.length > 1) {
+  } else if (publicHttpRoutes.length > 1) {
     debug(
-      `Multiple HTTPRoutes found for service ${name} in namespace ${namespace}. This may indicate an issue with the service configuration.`,
+      `Multiple public HTTPRoutes found for service ${name} in namespace ${namespace}. This may indicate an issue with the service configuration.`,
     )
     return 'Unknown'
   }
 
-  const [httpRoute] = httpRoutes
+  const [httpRoute] = publicHttpRoutes
   const isAccepted = parseHTTPRouteStatus(httpRoute)
   return isAccepted ? 'Succeeded' : 'Unknown'
 }