Skip to content

chore: lower minimum knative k8s version #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ferruhcihan merged 2 commits into from
May 26, 2026
Merged

chore: lower minimum knative k8s version #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
666c37d
chore: lower miminum knative k8s version
ferruhcihan May 21, 2026
3ade4dc
Merge remote-tracking branch 'origin/main' into APL-1891
ferruhcihan May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/utils/k8sUtils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ describe('isK8sVersionAtLeast', () => {
})

describe('isKnativeSupported', () => {
it('returns true for Kubernetes 1.33', () => {
expect(isKnativeSupported('v1.33.0')).toBe(true)
it('returns true for Kubernetes 1.31', () => {
expect(isKnativeSupported('v1.31.0')).toBe(true)
})

it('returns true for Kubernetes above 1.33', () => {
it('returns true for Kubernetes above 1.31', () => {
expect(isKnativeSupported('v1.35.3')).toBe(true)
})

it('returns false for Kubernetes below 1.33', () => {
expect(isKnativeSupported('v1.32.0')).toBe(false)
it('returns false for Kubernetes below 1.31', () => {
expect(isKnativeSupported('v1.30.0')).toBe(false)
})
})
2 changes: 1 addition & 1 deletion src/validators.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ export const OBJECT_STORAGE_UI_EXCLUSIONS = json<string[]>({
})
export const MIN_KNATIVE_K8S_VERSION = str({
desc: 'Minimum Kubernetes version required for Knative support',
default: '1.33.0',
default: '1.31.0',
})
export const API_NAMESPACE = str({
desc: 'The Kubernetes namespace where apl-api status resources are stored',
Expand Down
Loading