feat: Git configure edit modal#1017
Open
dennisvankekem wants to merge 2 commits into
Open
Conversation
9 tasks
There was a problem hiding this comment.
Pull request overview
Adds a GET /v2/git endpoint and supporting plumbing to let the console’s “Git configure edit” modal prefill existing Git configuration values from the API.
Changes:
- Extends
SettingsInfo.otomi.gitto includeusername,password, andemail. - Adds
OtomiStack.getGitSettings()and a newGET /v2/gitoperation handler. - Updates OpenAPI routes and ACL for
AplGitto allow non-platform roles to read Git settings.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
src/otomi-stack.ts |
Adds git fields into getSettingsInfo() projection and introduces getGitSettings() helper. |
src/api/v2/git.ts |
Adds the GET /v2/git handler that returns current git settings. |
src/openapi/api.yaml |
Defines GET /v2/git in the API spec. |
src/openapi/settingsinfo.yaml |
Documents additional otomi.git fields in SettingsInfo. |
src/openapi/git.yaml |
Adjusts ACL so team roles can read AplGit. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
373
to
+377
| 'git.repoUrl', | ||
| 'git.branch', | ||
| 'git.username', | ||
| 'git.password', | ||
| 'git.email', |
Contributor
There was a problem hiding this comment.
I certainly think so, too. The password should never be there to read. Even if it may be encrypted there is no reason to send it back to the client at all.
Comment on lines
+666
to
+683
| async getGitSettings(): Promise<{ | ||
| repoUrl?: string | ||
| branch?: string | ||
| username?: string | ||
| password?: string | ||
| email?: string | ||
| }> { | ||
| const settingsInfo = await this.getSettingsInfo() | ||
| const git = settingsInfo.otomi?.git | ||
|
|
||
| return { | ||
| repoUrl: git?.repoUrl, | ||
| branch: git?.branch, | ||
| username: git?.username, | ||
| password: git?.password, | ||
| email: git?.email, | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I agree with that. Sending back passwords, even in encrypted form, suggests that secrets are exposed. Console can just insert placeholders.
Comment on lines
+12
to
+18
| export const getGitSettings = async (req: OpenApiRequestExt, res: Response): Promise<void> => { | ||
| debug('getGitSettings') | ||
|
|
||
| const gitSettings = await req.otomi.getGitSettings() | ||
|
|
||
| res.json(gitSettings) | ||
| } |
Comment on lines
+65
to
+71
| password: | ||
| type: string | ||
| description: The password or personal access token used to authenticate with the Git repository. | ||
| email: | ||
| type: string | ||
| description: The email address used for Git commit author information. | ||
| format: email |
Comment on lines
+2044
to
+2047
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/AplGit' |
j-zimnowoda
reviewed
Jun 18, 2026
| - update-any | ||
| teamAdmin: [] | ||
| teamMember: [] | ||
| teamAdmin: |
Contributor
There was a problem hiding this comment.
why allowing teams to read this data?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
console: linode/apl-console#806
api: #1017