Skip to content

feat: migrate teamsettings to v2 endpoint#699

Merged
CasLubbers merged 14 commits intomainfrom
APL-709
May 7, 2025
Merged

feat: migrate teamsettings to v2 endpoint#699
CasLubbers merged 14 commits intomainfrom
APL-709

Conversation

@CasLubbers
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 17, 2025

Coverage report

St.
Category Percentage Covered / Total
🔴 Statements
49.45% (-0.82% 🔻)
2216/4481
🔴 Branches
34.2% (-0.01% 🔻)
356/1041
🔴 Functions
41.41% (-1.25% 🔻)
405/978
🔴 Lines
49.84% (-0.81% 🔻)
2084/4181
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🔴 api/v2/teams.ts 53.85% 0% 33.33% 53.85%
🔴
... / {teamId}.ts
42.86% 100% 20% 42.86%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴 otomi-stack.ts
19.74% (-0.74% 🔻)
16.41% (+0.42% 🔼)
17.76% (+0.25% 🔼)
19.72% (-0.89% 🔻)
🔴 app.ts
46.92% (-13.23% 🔻)
6.67% (+6.67% 🔼)
27.78% (-11.11% 🔻)
47.11% (-14.24% 🔻)
🟡
... / session.ts
65.71% (-1.43% 🔻)
66.67%
44.44% (-11.11% 🔻)
64.41%
🔴 repo.ts 24.18%
2.56% (-0.03% 🔻)
16% 24.83%
🟢
... / RepoService.ts
78.9% (-5.21% 🔻)
68.42% (+1.75% 🔼)
66.67% (-11.33% 🔻)
84.69% (-2.93% 🔻)
🟡
... / TeamConfigService.ts
71.75% (-0.77% 🔻)
60.71% (+3.09% 🔼)
70.53% (-1.81% 🔻)
70.62% (-0.88% 🔻)

Test suite run success

289 tests passing in 12 suites.

Report generated by 🧪jest coverage report action from 93b101c

@CasLubbers CasLubbers requested review from ferruhcihan and merll and removed request for ferruhcihan April 17, 2025 12:12
Comment thread src/repo.ts Outdated
Comment thread src/api.authz.test.ts Outdated
Comment thread src/api/v2/teams.ts Outdated
Copy link
Copy Markdown
Contributor

@merll merll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, otherwise looks good.

Comment thread src/.DS_Store Outdated
@ferruhcihan ferruhcihan self-assigned this May 6, 2025
Copy link
Copy Markdown
Collaborator

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻
Should we also open a follow-up PR in apl-console to update the generated Redux store accordingly?

@CasLubbers
Copy link
Copy Markdown
Contributor Author

LGTM 👍🏻 Should we also open a follow-up PR in apl-console to update the generated Redux store accordingly?

@ferruhcihan Yes good one

@CasLubbers CasLubbers enabled auto-merge (squash) May 7, 2025 17:13
@CasLubbers CasLubbers merged commit 507170f into main May 7, 2025
4 checks passed
@CasLubbers CasLubbers deleted the APL-709 branch May 7, 2025 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants