Skip to content

feat: separate domain from netpol addresss validation #983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
merll wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat: separate domain from netpol addresss validation #983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4c6ac1
feat: separate domain from netpol (fqdn, wildcard, ip) validation
merll Apr 24, 2026
e0da7cf
Merge remote-tracking branch 'origin/main' into APL-1756
svcAPLBot Apr 24, 2026
f5330a2
fix: expression without wildcard
merll Apr 24, 2026
0193828
Merge remote-tracking branch 'origin/main' into APL-1756
svcAPLBot Apr 29, 2026
e1ef1bb
Merge remote-tracking branch 'origin/main' into APL-1756
svcAPLBot May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/openapi/definitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,7 @@ dns:
required:
- other
domain:
pattern: ^((([a-zA-Z0-9]|[a-zA-Z0-9][a-zA-Z0-9\-]*[a-zA-Z0-9])\.)*([A-Za-z0-9]|[A-Za-z0-9][A-Za-z0-9\-]*[A-Za-z0-9]))|([a-f0-9:]+:+)+[a-f0-9]+$
pattern: ^([a-zA-Z0-9]([a-zA-Z0-9\-]*[a-zA-Z0-9])?\.)*[a-zA-Z0-9]([a-zA-Z0-9\-]*[a-zA-Z0-9])?$
x-message: a valid fully qualified domain name (FQDN)
type: string
domainSuffix:
Expand Down Expand Up @@ -1118,6 +1118,10 @@ volumes:
$ref: 'definitions.yaml#/idName'
type: object
type: array
wildcardDomainOrIp:
pattern: ^((\*\.)?([a-zA-Z0-9]([a-zA-Z0-9\-]*[a-zA-Z0-9])?\.)*[a-zA-Z0-9]([a-zA-Z0-9\-]*[a-zA-Z0-9])?|([a-f0-9:]+:+)+[a-f0-9]+)$
description: FQDN, wildcard domain, or IP address
type: string
wordCharacterPattern:
type: string
pattern: ^[^\s]+$
Expand Down
4 changes: 2 additions & 2 deletions src/openapi/netpol.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,8 @@ ruleType:
type: object
properties:
domain:
title: FQDN or IP address
$ref: 'definitions.yaml#/domain'
title: FQDN, wildcard domain, or IP address
$ref: 'definitions.yaml#/wildcardDomainOrIp'
ports:
type: array
items:
Expand Down
Loading