Skip to content

feat: service page using new components#1996

Merged
ElderMatt merged 50 commits into
mainfrom
APL-537
Apr 23, 2025
Merged

feat: service page using new components#1996
ElderMatt merged 50 commits into
mainfrom
APL-537

Conversation

@ElderMatt
Copy link
Copy Markdown
Contributor

@ElderMatt ElderMatt commented Mar 12, 2025 •
edited
Loading

Also see other PRs:

Checklist

  • Architecture Design Records have been added as adr/*.md and appended to list in adr/_index.md, if applicable.
  • The values-schema.yaml file and test/** fixtures have been updated to reflect code changes, if applicable.
  • The OpenApi Schema from redkubes/otomi-api project is compatible with definitions from values-schema.yaml file, if applicable.
  • Helm releases are meeting otomi's baseline security policies, if applicable.
  • Helm chart and helmfile changes are tested against upgrade scenario, if applicable.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 12, 2025 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements
49.07% (+0.45% 🔼)
 1061/2162
🔴 Branches
33.13% (+0.89% 🔼)
 212/640
🔴 Functions
40.67% (+1.14% 🔼)
 122/300
🔴 Lines
48.4% (+0.48% 🔼)
 938/1938

Test suite run success

92 tests passing in 9 suites.

Report generated by 🧪jest coverage report action from 7355487

This was referenced Mar 12, 2025
Closed
Merged
dennisvankekem
dennisvankekem reviewed Mar 12, 2025
View reviewed changes
Comment thread versions.yaml Outdated
ferruhcihan
ferruhcihan reviewed Mar 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ferruhcihan ferruhcihan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some merge conflicts due to the APL-502 changes. Other than that, LGTM.

merll
merll reviewed Mar 24, 2025
View reviewed changes
Comment thread src/cmd/migrate.ts Outdated
j-zimnowoda
j-zimnowoda reviewed Apr 15, 2025
View reviewed changes
Comment thread src/common/values.ts Outdated
@ElderMatt ElderMatt mentioned this pull request Apr 16, 2025
Merged
j-zimnowoda
j-zimnowoda reviewed Apr 16, 2025
View reviewed changes
Comment thread values-changes.yaml
@ElderMatt ElderMatt requested a review from j-zimnowoda April 17, 2025 07:27
dennisvankekem
dennisvankekem reviewed Apr 23, 2025
View reviewed changes
Comment thread src/cmd/migrate.ts Outdated
@ElderMatt ElderMatt requested a review from merll April 23, 2025 13:06
@ElderMatt ElderMatt dismissed j-zimnowoda’s stale review April 23, 2025 13:06

have been removed

merll
merll reviewed Apr 23, 2025
View reviewed changes
Comment thread src/cmd/migrate.ts Outdated
merll
merll approved these changes Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@merll merll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion, otherwise looks good.

@ElderMatt @merll
Update src/cmd/migrate.ts
7355487 
Co-authored-by: merll <merll@users.noreply.github.com>
@ElderMatt ElderMatt merged commit f3b5745 into main Apr 23, 2025
7 checks passed
@ElderMatt ElderMatt deleted the APL-537 branch April 23, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ferruhcihan ferruhcihan ferruhcihan left review comments

@merll merll merll approved these changes

@CasLubbers CasLubbers CasLubbers approved these changes

@dennisvankekem dennisvankekem dennisvankekem approved these changes

@j-zimnowoda j-zimnowoda Awaiting requested review from j-zimnowoda j-zimnowoda is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ElderMatt @merll @j-zimnowoda @CasLubbers @dennisvankekem @ferruhcihan @svcAPLBot