ci: add BYO_GIT checkbox to the Deploy APL action#3436
Open
j-zimnowoda wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “Deploy APL” GitHub Actions workflow to optionally configure APL to use a predefined external Git repository for its values repo (“BYO_GIT”), controlled via a new workflow_dispatch checkbox. It adds secret validation and conditionally injects otomi.git.* Helm values during install when enabled.
Changes:
- Add a
BYO_GITboolean input to theworkflow_dispatchform. - Validate
BYO_GIT_PAT/BYO_GIT_URLsecrets whenBYO_GITis enabled. - When enabled, pass
otomi.git.repoUrl,otomi.git.password, andotomi.git.branchinto the APL install command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
This pull request adds support for a "Bring Your Own Git" (BYO_GIT) integration to the
integration.ymlGitHub Actions workflow. The main changes introduce a new input flag, validate required secrets, and pass these secrets to relevant jobs for use during installation.Key changes:
BYO_GIT input and validation:
BYO_GITto the workflow, allowing users to enable the BYO Git integration option.BYO_GIT_PATandBYO_GIT_URL) are set ifBYO_GITis enabled, failing early if they are missing.Secrets management and usage:
BYO_GIT_PATandBYO_GIT_URLsecrets to the relevant job environments to make them available during workflow execution.BYO_GIToption is enabled.🔍 Reviewer Notes
🧹 Checklist