[fix] CAPL dual-stack Cilium public IPv6 NodePort datapath#1050
Merged
Conversation
Upgrade the shared Cilium chart default to 1.18.7 and update the kubeadm dual-stack flavor to render explicit multi-NIC nodePort settings in the Cilium values template. Replace the old IPv4-only --nodeport-addresses flag with nodePort.addresses for both 0.0.0.0/0 and ::/0, add explicit devices for eth0 and eth1, and set directRoutingDevice to eth0. This fixes the public IPv6 NodePort datapath in generated CAPL manifests. With the dual-stack values rendered directly in the template, all intended datapaths should now be covered by the generated config.
komer3
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1050 +/- ##
=======================================
Coverage 67.88% 67.88%
=======================================
Files 71 71
Lines 6480 6480
=======================================
Hits 4399 4399
Misses 1808 1808
Partials 273 273 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
full flavor run passed successfully: https://github.com/linode/cluster-api-provider-linode/actions/runs/23459960400/job/68261687858 |
eljohnson92
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR updates the CAPL manifest generation sources for dual-stack Cilium so generated
kubeadm-dual-stackmanifests render the correct NodePort and device settings directly in the template.Changes included:
1.18.7devicesforeth0andeth1in the kubeadm dual-stack flavornodePort.addressesto both0.0.0.0/0and::/0nodePort.directRoutingDevicetoeth0--nodeport-addresses=0.0.0.0/0CLI flag from the same generated configWhy
The generated CAPL dual-stack manifest was not carrying the full Cilium values needed for the public IPv6 NodePort datapath. It still rendered an IPv4-only
--nodeport-addresses=0.0.0.0/0flag and dropped the explicit multi-NIC NodePort settings from the generated configuration.By moving the dual-stack NodePort settings into the rendered Cilium values template and using a single source of truth, the generated manifest now covers the public IPv6 NodePort datapath correctly. With these settings rendered directly, the intended datapaths should now all be working.
Verification
Verified by rendering the flavor locally with:
Confirmed in the rendered Cilium config:
version: 1.18.7devices: [eth0, eth1]nodePort.addressescontains both0.0.0.0/0and::/0nodePort.directRoutingDevice: eth0--nodeport-addresses=...extra arg