[feat]: implement maintenance watcher for linodeCluster#1075
Open
tchinmai7 wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds “maintenance awareness” to CAPL by querying Linode’s Account Maintenance API and surfacing upcoming scheduled maintenance on the corresponding Cluster API Machine objects as a MaintenanceScheduled condition, enabling operators to drive remediation via MachineHealthCheck.
Changes:
- Add
ListMaintenancesto the Linode client interfaces, tracing wrapper, and gomock clients. - Extend
LinodeClusterReconcilerto query scheduled maintenances (next 72h) and patch owning CAPIMachineconditions. - Add unit tests and user documentation for configuring
MachineHealthCheckto remediate machines scheduled for maintenance.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
observability/wrappers/linodeclient/linodeclient.gen.go |
Adds tracing wrapper method for ListMaintenances. |
mock/client.go |
Updates gomock clients to include ListMaintenances and a maintenance client mock. |
internal/controller/linodecluster_controller.go |
Implements maintenance lookup + patches MaintenanceScheduled onto owning CAPI Machines during cluster reconcile. |
internal/controller/linodecluster_controller_maintenance_test.go |
Adds unit tests for maintenance collection and condition patching behavior. |
docs/src/topics/health-checking.md |
Documents the new MaintenanceScheduled condition and MHC examples for remediation. |
clients/clients.go |
Extends LinodeClient interface with LinodeMaintenanceClient. |
Files not reviewed (2)
- mock/client.go: Language not supported
- observability/wrappers/linodeclient/linodeclient.gen.go: Language not supported
komer3
reviewed
May 15, 2026
komer3
reviewed
May 15, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1075 +/- ##
==========================================
- Coverage 69.23% 69.21% -0.02%
==========================================
Files 71 71
Lines 6566 6634 +68
==========================================
+ Hits 4546 4592 +46
- Misses 1725 1742 +17
- Partials 295 300 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Automatically detects linodes that are scheduled for maintenance, and adds a condition on the machines. Maintenance can be disruptive, depending on the workload running on the clusters, and operators may want to know ahead of time, and surge replace nodes. This allows operators to configure a
MachineHealthCheckto detect when machines are schedueld for maintenance and replace them.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: