[improvement] add validation admission webhook checks for resource name length#851
Merged
Conversation
470e81a to
a709771
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #851 +/- ##
==========================================
+ Coverage 63.65% 64.76% +1.11%
==========================================
Files 71 71
Lines 7827 7871 +44
==========================================
+ Hits 4982 5098 +116
+ Misses 2555 2465 -90
- Partials 290 308 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a709771 to
9dd1d3c
Compare
9dd1d3c to
3e10d34
Compare
amold1
approved these changes
Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Before it was possible to apply a resource that had a name that didn't fit the Linode API label length limitations. This adds a check on our validating admission webhooks so we can catch this before the user encounters a 400.
I also did some cleanup to standardize of our validating admission webhook logic.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: