Skip to content

[improvement] set an explicit struct for dataDisks instead of a map#853

Merged
eljohnson92 merged 1 commit into
mainfrom
kal-datadisks
Sep 4, 2025
Merged

[improvement] set an explicit struct for dataDisks instead of a map#853
eljohnson92 merged 1 commit into
mainfrom
kal-datadisks

Conversation

@eljohnson92

@eljohnson92 eljohnson92 commented Aug 28, 2025

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This PR enables the nomaps linter which requires us to change the spec.dataDisks from a map[string]instanceDisks to an explicit list of instance disks. despite this stricter API spec change it should not be a breaking change since our webhooks were validating that the only dataDisks specified were the ones updated in this PR anyways.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov

codecov Bot commented Aug 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.39474% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.21%. Comparing base (eaa5b92) to head (85a0418).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...nal/controller/linodemachine_controller_helpers.go 94.16% 4 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #853      +/-   ##
==========================================
+ Coverage   64.76%   65.21%   +0.44%     
==========================================
  Files          71       71              
  Lines        7871     7931      +60     
==========================================
+ Hits         5098     5172      +74     
+ Misses       2465     2456       -9     
+ Partials      308      303       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eljohnson92 eljohnson92 changed the title [improvement] set an explicit struct for dataDisks instead of a map [improvement][breaking] set an explicit struct for dataDisks instead of a map Sep 2, 2025
@AshleyDumaine AshleyDumaine changed the title [improvement][breaking] set an explicit struct for dataDisks instead of a map [improvement] set an explicit struct for dataDisks instead of a map Sep 3, 2025
@eljohnson92 eljohnson92 merged commit e435634 into main Sep 4, 2025
17 checks passed
@AshleyDumaine AshleyDumaine deleted the kal-datadisks branch September 9, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants