[improvement] set an explicit struct for dataDisks instead of a map#853
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 64.76% 65.21% +0.44%
==========================================
Files 71 71
Lines 7871 7931 +60
==========================================
+ Hits 5098 5172 +74
+ Misses 2465 2456 -9
+ Partials 308 303 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3141ce5 to
03809ee
Compare
03809ee to
cb0a559
Compare
cb0a559 to
80529ce
Compare
80529ce to
ea1e028
Compare
ea1e028 to
85a0418
Compare
AshleyDumaine
approved these changes
Sep 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enables the nomaps linter which requires us to change the
spec.dataDisksfrom amap[string]instanceDisksto an explicit list of instance disks. despite this stricter API spec change it should not be a breaking change since our webhooks were validating that the only dataDisks specified were the ones updated in this PR anyways.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: