[improvement] enable the requiredfields linter and make spec fields required#875
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
==========================================
+ Coverage 65.17% 66.22% +1.05%
==========================================
Files 71 71
Lines 7957 7959 +2
==========================================
+ Hits 5186 5271 +85
+ Misses 2469 2389 -80
+ Partials 302 299 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4467fd6 to
e6ef79a
Compare
e6ef79a to
fb39f9e
Compare
AshleyDumaine
approved these changes
Sep 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enabled the
requiredfieldslinter. This includes adding some requirements to allrequiredfields to ensure unless""or0were explicitly accepted we had a specified minimum(usually 1). this also includes makingspecrequired for all non-template resources, since that is practically the case. most code changes were around fixing unit test that were relying on the looser required validating with no minimum value to actually include all required valuesWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs: