Skip to content

[improvement] enable the requiredfields linter and make spec fields required#875

Merged
eljohnson92 merged 1 commit into
mainfrom
kal-required-fields
Sep 12, 2025
Merged

[improvement] enable the requiredfields linter and make spec fields required#875
eljohnson92 merged 1 commit into
mainfrom
kal-required-fields

Conversation

@eljohnson92

Copy link
Copy Markdown
Collaborator

What this PR does / why we need it:
This PR enabled the requiredfields linter. This includes adding some requirements to all required fields to ensure unless "" or 0 were explicitly accepted we had a specified minimum(usually 1). this also includes making spec required for all non-template resources, since that is practically the case. most code changes were around fixing unit test that were relying on the looser required validating with no minimum value to actually include all required values
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov

codecov Bot commented Sep 11, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.22%. Comparing base (39efc02) to head (fb39f9e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #875      +/-   ##
==========================================
+ Coverage   65.17%   66.22%   +1.05%     
==========================================
  Files          71       71              
  Lines        7957     7959       +2     
==========================================
+ Hits         5186     5271      +85     
+ Misses       2469     2389      -80     
+ Partials      302      299       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eljohnson92 eljohnson92 merged commit 2bbfc63 into main Sep 12, 2025
17 checks passed
@AshleyDumaine AshleyDumaine deleted the kal-required-fields branch September 24, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants