Skip to content

[CI] run nilaway through golangci-lint as a custom module#928

Merged
AshleyDumaine merged 1 commit into
mainfrom
nilaway
Oct 21, 2025
Merged

[CI] run nilaway through golangci-lint as a custom module#928
AshleyDumaine merged 1 commit into
mainfrom
nilaway

Conversation

@AshleyDumaine

@AshleyDumaine AshleyDumaine commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it: Doing this, we'll be able to use //nolint:nilaway to disable false positives if they come up in the future since this isn't supported when running nilaway in standalone mode.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@codecov

codecov Bot commented Oct 21, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.34%. Comparing base (dfdc4a5) to head (ab97eab).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #928   +/-   ##
=======================================
  Coverage   66.34%   66.34%           
=======================================
  Files          71       71           
  Lines        7961     7961           
=======================================
  Hits         5282     5282           
  Misses       2378     2378           
  Partials      301      301           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AshleyDumaine AshleyDumaine merged commit b1bf236 into main Oct 21, 2025
16 checks passed
@AshleyDumaine AshleyDumaine deleted the nilaway branch October 21, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants