WIP: Fix unit test results

Author: Andrews2024

cloud/linode/loadbalancers.go

@@ -127,7 +127,7 @@ func (l *loadbalancers) cleanupOldNodeBalancer(ctx context.Context, service *v1.
 
 	previousNB, err := l.getNodeBalancerByStatus(ctx, service)
 	if err != nil {
-		var targetError *lbNotFoundError
+		var targetError lbNotFoundError
 		if errors.As(err, &targetError) {
 			return nil
 		} else {
@@ -177,7 +177,7 @@ func (l *loadbalancers) GetLoadBalancer(ctx context.Context, clusterName string,
 
 	nb, err := l.getNodeBalancerForService(ctx, service)
 	if err != nil {
-		var targetError *lbNotFoundError
+		var targetError lbNotFoundError
 		if errors.As(err, &targetError) {
 			return nil, false, nil
 		} else {
@@ -252,30 +252,31 @@ func (l *loadbalancers) EnsureLoadBalancer(ctx context.Context, clusterName stri
 	var nb *linodego.NodeBalancer
 
 	nb, err = l.getNodeBalancerForService(ctx, service)
-	if err == nil {
-		if err = l.updateNodeBalancer(ctx, clusterName, service, nodes, nb); err != nil {
+	//nolint: errorlint //conversion to errors.Is() may break chainsaw tests
+	switch err.(type) {
+	case lbNotFoundError:
+		if service.GetAnnotations()[annotations.AnnLinodeNodeBalancerID] != "" {
+			// a load balancer annotation has been created so a NodeBalancer is coming, error out and retry later
+			klog.Infof("NodeBalancer created but not available yet, waiting...")
 			sentry.CaptureError(ctx, err)
 			return nil, err
 		}
-	} else {
-		var targetError *lbNotFoundError
-		if errors.As(err, &targetError) {
-			if service.GetAnnotations()[annotations.AnnLinodeNodeBalancerID] != "" {
-				// a load balancer annotation has been created so a NodeBalancer is coming, error out and retry later
-				klog.Infof("NodeBalancer created but not available yet, waiting...")
-				sentry.CaptureError(ctx, err)
-				return nil, err
-			}
 
-			if nb, err = l.buildLoadBalancerRequest(ctx, clusterName, service, nodes); err != nil {
-				sentry.CaptureError(ctx, err)
-				return nil, err
-			}
-			klog.Infof("created new NodeBalancer (%d) for service (%s)", nb.ID, serviceNn)
-		} else {
+		if nb, err = l.buildLoadBalancerRequest(ctx, clusterName, service, nodes); err != nil {
+			sentry.CaptureError(ctx, err)
+			return nil, err
+		}
+		klog.Infof("created new NodeBalancer (%d) for service (%s)", nb.ID, serviceNn)
+
+	case nil:
+		if err = l.updateNodeBalancer(ctx, clusterName, service, nodes, nb); err != nil {
 			sentry.CaptureError(ctx, err)
 			return nil, err
 		}
+
+	default:
+		sentry.CaptureError(ctx, err)
+		return nil, err
 	}
 
 	klog.Infof("NodeBalancer (%d) has been ensured for service (%s)", nb.ID, serviceNn)
@@ -552,16 +553,19 @@ func (l *loadbalancers) EnsureLoadBalancerDeleted(ctx context.Context, clusterNa
 	}
 
 	nb, err := l.getNodeBalancerForService(ctx, service)
-	if err != nil {
-		var targetError *lbNotFoundError
-		if errors.As(err, &targetError) {
-			klog.Infof("short-circuiting deletion for NodeBalancer for service (%s) as one does not exist: %s", serviceNn, err)
-			return nil
-		} else {
-			klog.Errorf("failed to get NodeBalancer for service (%s): %s", serviceNn, err)
-			sentry.CaptureError(ctx, err)
-			return err
-		}
+	//nolint: errorlint //conversion to errors.Is() may break chainsaw tests
+	switch getErr := err.(type) {
+	case nil:
+		break
+
+	case lbNotFoundError:
+		klog.Infof("short-circuiting deletion for NodeBalancer for service (%s) as one does not exist: %s", serviceNn, err)
+		return nil
+
+	default:
+		klog.Errorf("failed to get NodeBalancer for service (%s): %s", serviceNn, err)
+		sentry.CaptureError(ctx, getErr)
+		return err
 	}
 
 	if l.shouldPreserveNodeBalancer(service) {