Resolved linting errors

Author: Andrews2024

cloud/linode/loadbalancers_test.go

@@ -2261,98 +2261,6 @@ func testUpdateLoadBalancerUpdateFirewallACL(t *testing.T, client *linodego.Clie
 		t.Errorf("expected non nil IPv4, got %v", fwIPs)
 	}
 
-	if len(*fwIPs) != 2 {
-		t.Errorf("expected two IPv4 ips, got %v", fwIPs)
-	}
-
-	if firewallsNew[0].Rules.Inbound[0].Addresses.IPv6 == nil {
-		t.Errorf("expected non nil IPv6, got %v", firewallsNew[0].Rules.Inbound[0].Addresses.IPv6)
-	}
-
-	if len(*firewallsNew[0].Rules.Inbound[0].Addresses.IPv6) != 2 {
-		t.Errorf("expected two IPv6 ips, got %v", firewallsNew[0].Rules.Inbound[0].Addresses.IPv6)
-	}
-
-	// Update ips in allowList
-	svc.ObjectMeta.SetAnnotations(map[string]string{
-		annotations.AnnLinodeCloudFirewallACL: `{
-			"allowList": {
-				"ipv4": ["2.2.2.1/32", "3.3.3.3/32"],
-				"ipv6": ["dead::/128", "dead:bee::/128"]
-			}
-		}`,
-	})
-
-	err = lb.UpdateLoadBalancer(context.TODO(), "linodelb", svc, nodes)
-	if err != nil {
-		t.Errorf("UpdateLoadBalancer returned an error: %s", err)
-	}
-
-	nbUpdated, err = lb.getNodeBalancerByStatus(context.TODO(), svc)
-	if err != nil {
-		t.Fatalf("failed to get NodeBalancer via status: %s", err)
-	}
-
-	firewallsNew, err = lb.client.ListNodeBalancerFirewalls(context.TODO(), nbUpdated.ID, &linodego.ListOptions{})
-	if err != nil {
-		t.Fatalf("failed to List Firewalls %s", err)
-	}
-
-	if len(firewallsNew) == 0 {
-		t.Fatalf("No attached firewalls found")
-	}
-
-	fwIPs = firewallsNew[0].Rules.Inbound[0].Addresses.IPv4
-	if fwIPs == nil {
-		t.Errorf("expected non nil IPv4, got %v", fwIPs)
-	}
-
-	if len(*fwIPs) != 2 {
-		t.Errorf("expected two IPv4 ips, got %v", fwIPs)
-	}
-
-	if firewallsNew[0].Rules.Inbound[0].Addresses.IPv6 == nil {
-		t.Errorf("expected non nil IPv6, got %v", firewallsNew[0].Rules.Inbound[0].Addresses.IPv6)
-	}
-
-	if len(*firewallsNew[0].Rules.Inbound[0].Addresses.IPv6) != 2 {
-		t.Errorf("expected two IPv6 ips, got %v", firewallsNew[0].Rules.Inbound[0].Addresses.IPv6)
-	}
-
-	// remove one ipv4 and one ipv6 ip from allowList
-	svc.ObjectMeta.SetAnnotations(map[string]string{
-		annotations.AnnLinodeCloudFirewallACL: `{
-			"allowList": {
-				"ipv4": ["3.3.3.3/32"],
-				"ipv6": ["dead:beef::/128"]
-			}
-		}`,
-	})
-
-	err = lb.UpdateLoadBalancer(context.TODO(), "linodelb", svc, nodes)
-	if err != nil {
-		t.Errorf("UpdateLoadBalancer returned an error: %s", err)
-	}
-
-	nbUpdated, err = lb.getNodeBalancerByStatus(context.TODO(), svc)
-	if err != nil {
-		t.Fatalf("failed to get NodeBalancer via status: %s", err)
-	}
-
-	firewallsNew, err = lb.client.ListNodeBalancerFirewalls(context.TODO(), nbUpdated.ID, &linodego.ListOptions{})
-	if err != nil {
-		t.Fatalf("failed to List Firewalls %s", err)
-	}
-
-	if len(firewallsNew) == 0 {
-		t.Fatalf("No attached firewalls found")
-	}
-
-	fwIPs = firewallsNew[0].Rules.Inbound[0].Addresses.IPv4
-	if fwIPs == nil {
-		t.Errorf("expected non nil IPv4, got %v", fwIPs)
-	}
-
 	if len(*fwIPs) != 1 {
 		t.Errorf("expected one IPv4, got %v", fwIPs)
 	}