Skip to content

Commit 6c8aa28

Browse files
committed
fix(Makefile): correct .PHONY declarations
- Fix duplicate .PHONY: lint on line 85, should be .PHONY: nilcheck - Fix lowercase .phony directives (GNU Make is case-sensitive) .phony has no effect; .PHONY is required
1 parent f450e88 commit 6c8aa28

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

Makefile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ vet: fmt
8282
lint: golangci-lint
8383
$(GOLANGCI_LINT) run -c .golangci.yml --fix
8484

85-
.PHONY: lint
85+
.PHONY: nilcheck
8686
nilcheck: golangci-lint-nilaway ## Run nilaway against code.
8787
$(GOLANGCI_LINT_NILAWAY) run -c .golangci-nilaway.yml
8888

@@ -304,12 +304,12 @@ $(CLUSTERCTL): $(LOCALBIN)
304304
curl -fsSL https://github.com/kubernetes-sigs/cluster-api/releases/download/$(CLUSTERCTL_VERSION)/clusterctl-$(OS)-$(ARCH_SHORT) -o $(CLUSTERCTL)
305305
chmod +x $(CLUSTERCTL)
306306

307-
.phony: golangci-lint-nilaway
307+
.PHONY: golangci-lint-nilaway
308308
golangci-lint-nilaway: $(GOLANGCI_LINT_NILAWAY)
309309
$(GOLANGCI_LINT_NILAWAY): $(GOLANGCI_LINT) # Build golangci-lint-nilaway from custom configuration.
310310
$(GOLANGCI_LINT) custom
311311

312-
.phony: golangci-lint
312+
.PHONY: golangci-lint
313313
golangci-lint: $(GOLANGCI_LINT)
314314
$(GOLANGCI_LINT): # Build golangci-lint from tools folder.
315315
GOBIN=$(LOCALBIN) go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION)

0 commit comments

Comments
 (0)