Skip to content

Commit c89d74e

Browse files
committed
Fix IPv6 backend lint and docs wording
1 parent b6e521f commit c89d74e

3 files changed

Lines changed: 7 additions & 3 deletions

File tree

cloud/linode/loadbalancers_test.go

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4283,7 +4283,10 @@ func Test_buildLoadBalancerRequestPreservesVPCConfigForIPv6Backends(t *testing.T
42834283

42844284
client := linodego.NewClient(http.DefaultClient)
42854285
client.SetBaseURL(ts.URL)
4286-
lb := newLoadbalancers(&client, "us-west").(*loadbalancers)
4286+
lb, ok := newLoadbalancers(&client, "us-west").(*loadbalancers)
4287+
if !ok {
4288+
t.Fatal("type assertion failed")
4289+
}
42874290

42884291
fake.vpc[1] = &linodego.VPC{
42894292
ID: 1,

deploy/chart/values.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -108,8 +108,8 @@ tolerations:
108108
# This can also be controlled per-service using the "service.beta.kubernetes.io/linode-loadbalancer-enable-ipv6-ingress" annotation
109109
# enableIPv6ForLoadBalancers: true
110110

111-
# Enable public IPv6 backend addresses for newly created non-VPC NodeBalancer services
112-
# Existing services are not migrated automatically, and all selected backend nodes must have public IPv6
111+
# Enable IPv6 backend addresses for NodeBalancer services
112+
# Existing services can be kept on IPv4 by setting service.beta.kubernetes.io/linode-loadbalancer-enable-ipv6-backends: "false", and all selected backend nodes must have the required IPv6 address
113113
# This can also be controlled per-service using the "service.beta.kubernetes.io/linode-loadbalancer-enable-ipv6-backends" annotation
114114
# enableIPv6ForNodeBalancerBackends: false
115115

docs/configuration/loadbalancer.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ When IPv6 backends are enabled:
7474
- both VPC-backed and non-VPC-backed NodeBalancer services are affected
7575
- when VPC-backed NodeBalancers are enabled, CCM preserves the NodeBalancer VPC configuration instead of dropping it
7676
- enabling the global `--enable-ipv6-for-nodebalancer-backends` flag can migrate existing eligible NodeBalancer services from IPv4 to IPv6 backends during reconcile
77+
- to keep an existing Service on IPv4 while the global flag is enabled, set `service.beta.kubernetes.io/linode-loadbalancer-enable-ipv6-backends: "false"` on that Service
7778
- every selected backend node must have an IPv6 address in the currently selected backend path
7879
- the workload cluster and Service must be configured for dual-stack networking
7980
- reconciliation fails and CCM logs an error if a selected backend node does not have the required IPv6 address

0 commit comments

Comments
 (0)