[feat] : enable nodeipamcontroller within CCM#366
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #366 +/- ##
==========================================
+ Coverage 72.98% 73.37% +0.38%
==========================================
Files 14 15 +1
Lines 2599 2670 +71
==========================================
+ Hits 1897 1959 +62
- Misses 537 544 +7
- Partials 165 167 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
78578d0 to
5d6cba9
Compare
5d6cba9 to
0719224
Compare
komer3
reviewed
Apr 2, 2025
b31de9f to
fa3eeda
Compare
08f517d to
4a622a2
Compare
10 tasks
hcwagner
pushed a commit
to hcwagner/linode-cloud-controller-manager
that referenced
this pull request
Jun 11, 2025
* enable nodeipamcontroller within CCM * fix linting errors * add documentation * update docs, add kube-controller-manager flag which should not be set * fix helm chart templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General:
This PR enables CCM to also do node IPAM management. To enable nodeipam-controller, one needs to set
--allocate-node-cidrsalong withcluster-cidrflag.Pull Request Guidelines: