[improvement] Refactor code blocks ignored by errorlint#370
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 73.48% 73.15% -0.34%
==========================================
Files 15 15
Lines 2682 2675 -7
==========================================
- Hits 1971 1957 -14
- Misses 544 547 +3
- Partials 167 171 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rahulait
reviewed
Apr 11, 2025
7177768 to
bfe6e35
Compare
rahulait
approved these changes
Apr 15, 2025
hcwagner
pushed a commit
to hcwagner/linode-cloud-controller-manager
that referenced
this pull request
Jun 11, 2025
* Swapped linodego.Error blocks for errors.As() * Swapped switch cases for lbNotFoundError blocks with errors.As() * WIP: Fix unit test results * Finished resolving unit test failures * WIP: EnsureLoadBalancerDeleted targetError as non-pointer * Added default case that got removed --------- Co-authored-by: Rahul Sharma <rahulait@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General:
As mentioned in PR 349, several errorlint errors were ignored because attempting to fix them resulted in two chainsaw tests breaking. This PR resolves the errorlint errors so we avoid issues with wrapped errors.
Pull Request Guidelines: