feat(helm): add podAnnotations and podLabels#396
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
Coverage 74.41% 74.41%
=======================================
Files 16 16
Lines 2865 2865
=======================================
Hits 2132 2132
Misses 550 550
Partials 183 183 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2b81ae7 to
09e9490
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces new configuration options for customizing pod annotations and labels in the Helm chart.
- Adds default empty values for podAnnotations and podLabels in values.yaml
- Incorporates these values into the daemonset template to allow dynamic annotation and label injection
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| deploy/chart/values.yaml | Added configuration entries for podAnnotations and podLabels |
| deploy/chart/templates/daemonset.yaml | Injects the new podAnnotations and podLabels into daemonset metadata |
Comments suppressed due to low confidence (2)
deploy/chart/values.yaml:124
- [nitpick] Consider expanding this comment to provide more context on how podAnnotations and podLabels interact with the chart templates.
# Add podAnnotations and podLabels for customization
deploy/chart/templates/daemonset.yaml:23
- [nitpick] Verify that the indentation level for the injected 'annotations:' field meets the desired YAML structure, ensuring consistency with other metadata fields.
{{- with .Values.podAnnotations }}
09e9490 to
3dee7ca
Compare
09e9490 to
c4c6b31
Compare
hcwagner
pushed a commit
to hcwagner/linode-cloud-controller-manager
that referenced
this pull request
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General:
Pull Request Guidelines: