Skip to content

[improvement][breaking] : remove deprecated vpcname flag#417

Merged
rahulait merged 1 commit intomainfrom
remove-vpcname-option
Jul 21, 2025
Merged

[improvement][breaking] : remove deprecated vpcname flag#417
rahulait merged 1 commit intomainfrom
remove-vpcname-option

Conversation

@rahulait
Copy link
Copy Markdown
Contributor

@rahulait rahulait commented Jul 20, 2025

General:

Its been more than 8+ months since we deprecated vpcname flag. This PR removes the deprecated flag.

Note:
This is a breaking change for those who are running within VPC and haven't updated to start using vpcnames if they are currently using vpcname. One should start using the newer flags to avoid any issues.

  • Have you removed all sensitive information, including but not limited to access keys and passwords?
  • Have you checked to ensure there aren't other open or closed Pull Requests for the same bug/feature/question?

Pull Request Guidelines:

  1. Does your submission pass tests?
  2. Have you added tests?
  3. Are you addressing a single feature in this PR?
  4. Are your commits atomic, addressing one change per commit?
  5. Are you following the conventions of the language?
  6. Have you saved your large formatting changes for a different PR, so we can focus on your work?
  7. Have you explained your rationale for why this feature is needed?
  8. Have you linked your PR to an open issue

@github-actions github-actions Bot added the improvement for improvements in existing functionality in the changelog. label Jul 20, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.33%. Comparing base (5a59a82) to head (9f075c5).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
- Coverage   75.39%   75.33%   -0.06%     
==========================================
  Files          16       16              
  Lines        2983     2976       -7     
==========================================
- Hits         2249     2242       -7     
  Misses        545      545              
  Partials      189      189              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulait rahulait merged commit 974299b into main Jul 21, 2025
11 checks passed
@komer3 komer3 deleted the remove-vpcname-option branch July 21, 2025 14:20
@rahulait rahulait changed the title [improvement] : remove deprecated vpcname flag [improvement][breaking] : remove deprecated vpcname flag Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement for improvements in existing functionality in the changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants