fix(Makefile): correct .PHONY declarations#547
Closed
Dereku92 wants to merge 1 commit intolinode:mainfrom
Closed
Conversation
- Fix duplicate .PHONY: lint on line 85, should be .PHONY: nilcheck - Fix lowercase .phony directives (GNU Make is case-sensitive) .phony has no effect; .PHONY is required
Dereku92
had a problem deploying
to
prod-external
GitHub Actions
Failure
Dereku92
had a problem deploying
to
prod-external
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues in the Makefile:
Duplicate
.PHONY: linton line 85 — this should be.PHONY: nilchecksince it precedes thenilchecktarget, not thelinttarget (which already has its own.PHONYon line 81).Lowercase
.phonydirectives forgolangci-lint-nilawayandgolangci-linttargets — GNU Make's.PHONYis case-sensitive. The lowercase.phonyis silently ignored, meaning these targets are not correctly marked as phony and could conflict with files of the same name.Small fix, no functional change beyond correct Make behavior.