From 6c8aa285c2a72406612ffef782b2e8a45e2bd8e8 Mon Sep 17 00:00:00 2001 From: "Derek U." Date: Sat, 21 Mar 2026 18:14:08 +0800 Subject: [PATCH] fix(Makefile): correct .PHONY declarations - Fix duplicate .PHONY: lint on line 85, should be .PHONY: nilcheck - Fix lowercase .phony directives (GNU Make is case-sensitive) .phony has no effect; .PHONY is required --- Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index 2ade9d75..b5e18e1b 100644 --- a/Makefile +++ b/Makefile @@ -82,7 +82,7 @@ vet: fmt lint: golangci-lint $(GOLANGCI_LINT) run -c .golangci.yml --fix -.PHONY: lint +.PHONY: nilcheck nilcheck: golangci-lint-nilaway ## Run nilaway against code. $(GOLANGCI_LINT_NILAWAY) run -c .golangci-nilaway.yml @@ -304,12 +304,12 @@ $(CLUSTERCTL): $(LOCALBIN) curl -fsSL https://github.com/kubernetes-sigs/cluster-api/releases/download/$(CLUSTERCTL_VERSION)/clusterctl-$(OS)-$(ARCH_SHORT) -o $(CLUSTERCTL) chmod +x $(CLUSTERCTL) -.phony: golangci-lint-nilaway +.PHONY: golangci-lint-nilaway golangci-lint-nilaway: $(GOLANGCI_LINT_NILAWAY) $(GOLANGCI_LINT_NILAWAY): $(GOLANGCI_LINT) # Build golangci-lint-nilaway from custom configuration. $(GOLANGCI_LINT) custom -.phony: golangci-lint +.PHONY: golangci-lint golangci-lint: $(GOLANGCI_LINT) $(GOLANGCI_LINT): # Build golangci-lint from tools folder. GOBIN=$(LOCALBIN) go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@$(GOLANGCI_LINT_VERSION)