Various test fixes to unblock upcoming release

Author: lgarber-akamai

test/integration/models/image/test_image.py

@@ -1,22 +1,46 @@
 from io import BytesIO
-from test.integration.conftest import get_region, get_regions
+from test.integration.conftest import get_regions
 from test.integration.helpers import get_test_label
 
 import polling
 import pytest
 
+from linode_api4 import LinodeClient
 from linode_api4.objects import Image
 
+DISALLOWED_IMAGE_REGIONS = {
+    "gb-lon",
+    "au-mel",
+    "sg-sin-2",
+    "jp-tyo-3",
+}
+
+
+def get_image_upload_regions(client: LinodeClient):
+    """
+    This is necessary because the API does not currently expose
+        a capability for regions that allow custom image uploads.
+
+        In the future, we should remove this if the API exposes a custom images capability or
+        if all Object Storage regions support custom images.
+    """
+
+    return [
+        region
+        for region in get_regions(
+            client,
+            capabilities={"Linodes", "Object Storage"},
+            site_type="core",
+        )
+        if region.id not in DISALLOWED_IMAGE_REGIONS
+    ]
+
 
 @pytest.fixture(scope="session")
 def image_upload_url(test_linode_client):
     label = get_test_label() + "_image"
 
-    region = get_region(
-        test_linode_client,
-        capabilities={"Linodes", "Object Storage"},
-        site_type="core",
-    )
+    region = get_image_upload_regions(test_linode_client)[0]
 
     test_linode_client.image_create_upload(
         label, region.id, "integration test image upload"
@@ -38,9 +62,7 @@ def test_uploaded_image(test_linode_client):
 
     label = get_test_label() + "_image"
 
-    regions = get_regions(
-        test_linode_client, capabilities={"Object Storage"}, site_type="core"
-    )
+    regions = get_image_upload_regions(test_linode_client)
 
     image = test_linode_client.image_upload(
         label,

test/integration/models/nodebalancer/test_nodebalancer.py

@@ -167,7 +167,9 @@ def test_update_nb(test_linode_client, create_nb):
         create_nb.id,
     )
 
-    nb.label = "ThisNewLabel"
+    new_label = f"{nb.label}-ThisNewLabel"
+
+    nb.label = new_label
     nb.client_udp_sess_throttle = 5
     nb.save()
 
@@ -176,7 +178,7 @@ def test_update_nb(test_linode_client, create_nb):
         create_nb.id,
     )
 
-    assert "ThisNewLabel" == nb_updated.label
+    assert new_label == nb_updated.label
     assert 5 == nb_updated.client_udp_sess_throttle
 
 
@@ -215,7 +217,10 @@ def test_update_nb_node(test_linode_client, create_nb_config):
         create_nb_config.nodebalancer_id,
     )
     node = config.nodes[0]
-    node.label = "ThisNewLabel"
+
+    new_label = f"{node.label}-ThisNewLabel"
+
+    node.label = new_label
     node.weight = 50
     node.mode = "accept"
     node.save()
@@ -226,7 +231,7 @@ def test_update_nb_node(test_linode_client, create_nb_config):
         (create_nb_config.id, create_nb_config.nodebalancer_id),
     )
 
-    assert "ThisNewLabel" == node_updated.label
+    assert new_label == node_updated.label
     assert 50 == node_updated.weight
     assert "accept" == node_updated.mode