ACLP clone alert definition and addition of group by field in alerting APIs#704
Open
shkaruna wants to merge 12 commits into
Open
ACLP clone alert definition and addition of group by field in alerting APIs#704shkaruna wants to merge 12 commits into
shkaruna wants to merge 12 commits into
Conversation
Release v5.37.0
Release v5.39.0
Release v5.41.0
Release v5.42.0
Release v5.43.0
Release 5.44.0
shkaruna
force-pushed
the
feat/clone_and_group_by
branch
from
21396ef to
b957929
Compare
shkaruna
force-pushed
the
feat/clone_and_group_by
branch
from
b957929 to
3527e51
Compare
shkaruna
requested review from
ezilber-akamai and
psnoch-akamai
and removed request for
a team
shkaruna
changed the title
…to feat/clone_and_group_by
yec-akamai
added
new-feature
yec-akamai
reviewed
Jun 17, 2026
yec-akamai
left a comment
yec-akamai
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Just a small suggestion:
| The clone request creates a new alert definition based on the source | ||
| definition identified by ``id``. | ||
|
|
||
| API URL: POST /monitor/services/{service_type}/alert-definitions/{id}/clone |
Contributor
There was a problem hiding this comment.
Nit: we usually don't put the api url in the docstring.
Contributor
Author
There was a problem hiding this comment.
Removed the API URL
yec-akamai
previously approved these changes
Jun 17, 2026
Contributor
|
To fix the lint issue, can you reformat |
shkaruna
force-pushed
the
feat/clone_and_group_by
branch
from
1c55c34 to
db10d66
Compare
Contributor
Author
Fixed the lint issue |
yec-akamai
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR adds support for the group_by field on ACLP Monitor Alert Definitions and introduces a clone API operation, along with unit/integration tests.
Changes:
Add GroupBy (group_by) to alert definition class.
Add clone_alert_definition API.
Expand unit/integration tests and fixtures to cover group_by and cloning.
✔️ How to Test
What are the steps to reproduce the issue or verify the changes?
Not applicable
How do I run the relevant unit/integration tests?
Prerequisites:
Clone the repository
Prepare environment (zsh / macOS)
Create and activate venv:
python3 -m venv .venv
source .venv/bin/activate
install deps
python -m pip install --upgrade pip
Install runtime dependencies:
pip3 install requests polling deprecated
Install dev/test extras
pip3 install -e '.[dev,test]'
test deps
pip3 install pytest mock httpretty pytest-rerunfailures
Unit tests:
Run all unit tests:
python -m pytest test/unit -q
Run Monitor alert definition unit tests:
python -m pytest test/unit/groups/monitor_api_test.py -q -s -v
Integration tests:
python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_clone_alert_definition -q -s
python -m pytest test/integration/models/monitor/test_monitor.py::test_integration_create_get_update_delete_alert_definition -q -s